From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: -Wall Date: Tue, 5 Apr 2016 08:12:50 -0700 Organization: UCLA Computer Science Department Message-ID: <5703D5F2.4000708@cs.ucla.edu> References: <5702B7C9.6010805@cs.ucla.edu> <570304CB.4050409@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------040404090500010003070302" X-Trace: ger.gmane.org 1459869198 24016 80.91.229.3 (5 Apr 2016 15:13:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 5 Apr 2016 15:13:18 +0000 (UTC) Cc: emacs-devel@gnu.org To: Lars Magne Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 05 17:13:09 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1anSfC-0007Bd-Ah for ged-emacs-devel@m.gmane.org; Tue, 05 Apr 2016 17:13:06 +0200 Original-Received: from localhost ([::1]:37630 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anSfB-0005Re-FH for ged-emacs-devel@m.gmane.org; Tue, 05 Apr 2016 11:13:05 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48094) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anSf2-0005Jg-TD for emacs-devel@gnu.org; Tue, 05 Apr 2016 11:13:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1anSey-0001QL-Pp for emacs-devel@gnu.org; Tue, 05 Apr 2016 11:12:56 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:45983) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1anSey-0001Oi-HC for emacs-devel@gnu.org; Tue, 05 Apr 2016 11:12:52 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 786A9161267; Tue, 5 Apr 2016 08:12:51 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id asEP_ywJ8_0q; Tue, 5 Apr 2016 08:12:50 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id BD8FD16125C; Tue, 5 Apr 2016 08:12:50 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id jjYo-zmVTq2Z; Tue, 5 Apr 2016 08:12:50 -0700 (PDT) Original-Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 9C5F5161267; Tue, 5 Apr 2016 08:12:50 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:202741 Archived-At: This is a multi-part message in MIME format. --------------040404090500010003070302 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 04/05/2016 12:39 AM, Lars Magne Ingebrigtsen wrote: > warnings should be enabled by default (on Linux), but > they shouldn't be treated as errors. It's good at times to not treat them as errors, so I installed the attached patch to add that capability more clearly, with a new configure-time option --enable-gcc-warnings=warn-only. The attached patch makes this new option the default if you have a Git checkout of Emacs and GCC 5.3 or later. This shouldn't affect Eli any time soon, since he uses an old compiler. If this patch causes trouble by generating too many warnings on some platforms, we can dial it back by suppressing warnings on those platforms. But the latest GNU/Linux platforms running the latest GTK should be warnings-free. As others have noted in this thread, -Wall generates too many warnings. The --enable-gcc-warnings option suppresses GCC warnings that are false alarms for Emacs. It also enables some warnings that -Wall does not, but which work well with Emacs. --------------040404090500010003070302 Content-Type: application/x-patch; name="0001-Enable-GCC-warnings-in-developer-builds.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-Enable-GCC-warnings-in-developer-builds.patch" RnJvbSAwY2U5MjFhMTE2OWI5MGVmOWFhODM1NDJlOTdiOTkwMGIzMTE3YzRmIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBUdWUsIDUgQXByIDIwMTYgMDc6NTE6MjggLTA3MDAKU3ViamVjdDogW1BBVENI XSBFbmFibGUgR0NDIHdhcm5pbmdzIGluIGRldmVsb3BlciBidWlsZHMKTUlNRS1WZXJzaW9u OiAxLjAKQ29udGVudC1UeXBlOiB0ZXh0L3BsYWluOyBjaGFyc2V0PVVURi04CkNvbnRlbnQt VHJhbnNmZXItRW5jb2Rpbmc6IDhiaXQKCkhvd2V2ZXIsIGRvIG5vdCBmYWlsOyBqdXN0IGlz c3VlIHRoZSB3YXJuaW5ncy4gIEFkZCBhbiBvcHRpb24KLS1lbmFibGUtZ2NjLXdhcm5pbmdz PXdhcm4tb25seSB0byBjb25maWd1cmUsIHRvIGltcGxlbWVudCB0aGlzLgoqIElOU1RBTEws IGV0Yy9ORVdTOiBEb2N1bWVudCB0aGlzLgoqIGNvbmZpZ3VyZS5hYyAoZ2xfR0NDX1ZFUlNJ T05fSUZFTFNFKTogTmV3IG1hY3JvLCBmcm9tIGNvcmV1dGlscy4KKGdsX2djY193YXJuaW5n cywgV0VSUk9SX0NGTEFHUyk6IFVzZSBpdCB0byBhZGQgbmV3IG9wdGlvbi4KRG9u4oCZdCB0 cmVhdCAtLXdpdGgteC10b29sa2l0PW5vIGFzIGEgc3BlY2lhbCBjYXNlIHdoZW4gY29uZmln dXJpbmcKd2FybmluZ3MuCi0tLQogSU5TVEFMTCAgICAgIHwgIDggKysrKystLS0KIGNvbmZp Z3VyZS5hYyB8IDU0ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0t LS0tLS0tLS0tLS0tLQogZXRjL05FV1MgICAgIHwgIDYgKysrKysrCiAzIGZpbGVzIGNoYW5n ZWQsIDQ2IGluc2VydGlvbnMoKyksIDIyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL0lO U1RBTEwgYi9JTlNUQUxMCmluZGV4IDZmNTE2YmQuLjI3YWY2ZDkgMTAwNjQ0Ci0tLSBhL0lO U1RBTEwKKysrIGIvSU5TVEFMTApAQCAtMzE4LDkgKzMxOCwxMSBAQCBVc2UgLS1lbmFibGUt Z2NjLXdhcm5pbmdzIHRvIGVuYWJsZSBjb21waWxlLXRpbWUgY2hlY2tzIHRoYXQgd2Fybgog YWJvdXQgcG9zc2libHktcXVlc3Rpb25hYmxlIEMgY29kZS4gIFRoaXMgaXMgaW50ZW5kZWQg Zm9yIGRldmVsb3BlcnMKIGFuZCBpcyB1c2VmdWwgd2l0aCBHTlUtY29tcGF0aWJsZSBjb21w aWxlcnMuICBPbiBhIHJlY2VudCBHTlUgc3lzdGVtCiB0aGVyZSBzaG91bGQgYmUgbm8gd2Fy bmluZ3M7IG9uIG9sZGVyIGFuZCBvbiBub24tR05VIHN5c3RlbXMgdGhlCi1nZW5lcmF0ZWQg d2FybmluZ3MgbWF5IHN0aWxsIGJlIHVzZWZ1bCwgdGhvdWdoIHlvdSBtYXkgcHJlZmVyIGJ1 aWxkaW5nCi13aXRoICdtYWtlIFdFUlJPUl9DRkxBR1M9JyBzbyB0aGF0IHRoZSB3YXJuaW5n cyBhcmUgbm90IHRyZWF0ZWQgYXMKLWVycm9ycy4KK2dlbmVyYXRlZCB3YXJuaW5ncyBtYXkg c3RpbGwgYmUgdXNlZnVsLCB0aG91Z2ggeW91IG1heSBwcmVmZXIKK2NvbmZpZ3VyaW5nIHdp dGggLS1lbmFibGUtZ2NjLXdhcm5pbmdzPXdhcm4tb25seSBzbyB0aGV5IGFyZSBub3QKK3Ry ZWF0ZWQgYXMgZXJyb3JzLiAgVGhlIGRlZmF1bHQgaXMgLS1lbmFibGUtZ2NjLXdhcm5pbmdz PXdhcm4tb25seSBpZgoraXQgYXBwZWFycyB0byBiZSBhIGRldmVsb3BlciBidWlsZCwgYW5k IGlzIC0tZGlzYWJsZS1nY2Mtd2FybmluZ3MKK290aGVyd2lzZS4KIAogVXNlIC0tZGlzYWJs ZS1zaWxlbnQtcnVsZXMgdG8gY2F1c2UgJ21ha2UnIHRvIGdpdmUgbW9yZSBkZXRhaWxzIGFi b3V0CiB0aGUgY29tbWFuZHMgaXQgZXhlY3V0ZXMuICBUaGlzIGNhbiBiZSBoZWxwZnVsIHdo ZW4gZGVidWdnaW5nIGEgYnVpbGQKZGlmZiAtLWdpdCBhL2NvbmZpZ3VyZS5hYyBiL2NvbmZp Z3VyZS5hYwppbmRleCBmMzg0NmY0Li45MTdjYTNhIDEwMDY0NAotLS0gYS9jb25maWd1cmUu YWMKKysrIGIvY29uZmlndXJlLmFjCkBAIC04NDIsMTcgKzg0Miw0NCBAQCBBQ19ERUZVTgog ICBlc2FjCiBmaQogCisjIGdsX0dDQ19WRVJTSU9OX0lGRUxTRShbbWFqb3JdLCBbbWlub3Jd LCBbcnVuLWlmLWZvdW5kXSwgW3J1bi1pZi1ub3QtZm91bmRdKQorIyAtLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0KKyMgSWYgJENQUCBpcyBnY2MtTUFKT1IuTUlOT1Igb3IgbmV3ZXIsIHRoZW4g cnVuIFJVTi1JRi1GT1VORC4KKyMgT3RoZXJ3aXNlLCBydW4gUlVOLUlGLU5PVC1GT1VORC4K K0FDX0RFRlVOKFtnbF9HQ0NfVkVSU0lPTl9JRkVMU0VdLAorICBbQUNfUFJFUFJPQ19JRkVM U0UoCisgICAgW0FDX0xBTkdfUFJPR1JBTSgKKyAgICAgIFtbCisjaWYgKCQxKSA8IF9fR05V Q19fIHx8ICgoJDEpID09IF9fR05VQ19fICYmICgkMikgPD0gX19HTlVDX01JTk9SX18pCisv KiBvayAqLworI2Vsc2UKKyMgZXJyb3IgInlvdXIgdmVyc2lvbiBvZiBnY2MgaXMgb2xkZXIg dGhhbiAkMS4kMiIKKyNlbmRpZgorICAgICAgXV0pLAorICAgIF0sIFskM10sIFskNF0pCisg IF0KKykKKwogQUNfQVJHX0VOQUJMRShbZ2NjLXdhcm5pbmdzXSwKLSAgW0FTX0hFTFBfU1RS SU5HKFstLWVuYWJsZS1nY2Mtd2FybmluZ3NdLAotICAgICAgICAgICAgICAgICAgW3R1cm4g b24gbG90cyBvZiBHQ0Mgd2FybmluZ3MvZXJyb3JzLiBUaGlzIGlzIGludGVuZGVkIGZvcgot CQkgICBkZXZlbG9wZXJzLCBhbmQgbWF5IGdlbmVyYXRlIGZhbHNlIGFsYXJtcyB3aGVuIHVz ZWQKLQkJICAgd2l0aCBvbGRlciBvciBub24tR05VIGRldmVsb3BtZW50IHRvb2xzLl0pXSwK KyAgW0FTX0hFTFBfU1RSSU5HKFstLWVuYWJsZS1nY2Mtd2FybmluZ3NAPDpAPVRZUEVAOj5A XSwKKyAgICAgICAgICAgICAgICAgIFtjb250cm9sIGdlbmVyYXRpb24gb2YgR0NDIHdhcm5p bmdzLiAgVGhlIFRZUEUgJ3llcycKKwkJICAgbWVhbnMgdG8gZmFpbCBpZiBhbnkgd2Fybmlu Z3MgYXJlIGlzc3VlZDsgJ3dhcm4tb25seScKKwkJICAgbWVhbnMgaXNzdWUgd2FybmluZ3Mg d2l0aG91dCBmYWlsaW5nIChkZWZhdWx0IGZvcgorCQkgICBkZXZlbG9wZXIgYnVpbGRzKTsg J25vJyBtZWFucyBkaXNhYmxlIHdhcm5pbmdzCisJCSAgIChkZWZhdWx0IGZvciBub24tZGV2 ZWxvcGVyIGJ1aWxkcykuXSldLAogICBbY2FzZSAkZW5hYmxldmFsIGluCi0gICAgIHllc3xu bykgOzsKKyAgICAgeWVzfG5vfHdhcm4tb25seSkgOzsKICAgICAgKikgICAgICBBQ19NU0df RVJST1IoW2JhZCB2YWx1ZSAkZW5hYmxldmFsIGZvciBnY2Mtd2FybmluZ3Mgb3B0aW9uXSkg OzsKICAgIGVzYWMKICAgIGdsX2djY193YXJuaW5ncz0kZW5hYmxldmFsXSwKLSAgW2dsX2dj Y193YXJuaW5ncz1ub10KKyAgWyMgQnkgZGVmYXVsdCwgdXNlICd3YXJuLW9ubHknIGlmIGl0 IGxvb2tzIGxpa2UgdGhlIGludm9rZXIgb2YgJ2NvbmZpZ3VyZScKKyAgICMgaXMgYSBkZXZl bG9wZXIgYXMgb3Bwb3NlZCB0byBhIGJ1aWxkZXIuICBUaGlzIGlzIG1vc3QgbGlrZWx5IHRy dWUKKyAgICMgaWYgR0NDIGlzIHJlY2VudCBlbm91Z2ggYW5kIHRoZXJlIGlzIGEgLmdpdCBz dWJkaXJlY3Rvcnk7CisgICAjIGhvd2V2ZXIsIGlmIHRoZXJlIGlzIGFsc28gYSAudGFyYmFs bC12ZXJzaW9uIGZpbGUgaXQgaXMgcHJvYmFibHkKKyAgICMganVzdCBhIHJlbGllYXNlIGlt cG9ydGVkIGludG8gR2l0IGZvciBwYXRjaCBtYW5hZ2VtZW50LgorICAgZ2xfZ2NjX3dhcm5p bmdzPW5vCisgICB0ZXN0IC1kICIkc3JjZGlyIi8uZ2l0ICYmIHRlc3QgISAtZiAiJHNyY2Rp ciIvLnRhcmJhbGwtdmVyc2lvbiAmJgorICAgICBnbF9HQ0NfVkVSU0lPTl9JRkVMU0UoWzVd LCBbM10sIFtnbF9nY2Nfd2FybmluZ3M9d2Fybi1vbmx5XSldCiApCiAKICMgY2xhbmcgaXMg dW5kdWx5IHBpY2t5IGFib3V0IHNvbWUgdGhpbmdzLgpAQCAtODY4LDcgKzg5NSw3IEBAIEFD X0RFRlVOCiAKICMgV2hlbiBjb21waWxpbmcgd2l0aCBHQ0MsIHByZWZlciAtaXN5c3RlbSB0 byAtSSB3aGVuIGluY2x1ZGluZyBzeXN0ZW0KICMgaW5jbHVkZSBmaWxlcywgdG8gYXZvaWQg Z2VuZXJhdGluZyB1c2VsZXNzIGRpYWdub3N0aWNzIGZvciB0aGUgZmlsZXMuCi1BU19JRihb dGVzdCAiJGdsX2djY193YXJuaW5ncyIgIT0geWVzXSwKK0FTX0lGKFt0ZXN0ICRnbF9nY2Nf d2FybmluZ3MgPSBub10sCiAgWwogICBpc3lzdGVtPSctSScKICAgQVNfSUYoW3Rlc3QgIiRl bWFjc19jdl9jbGFuZyIgPSB5ZXNdLApAQCAtODkyLDcgKzkxOSw3IEBAIEFDX0RFRlVOCiAg ICAgICAgbnc9IiRudyAtV3dyaXRlLXN0cmluZ3MiCiAgICAgICAgOzsKICAgZXNhYwotICBB U19JRihbdGVzdCAteiAiJG53Il0sCisgIEFTX0lGKFt0ZXN0ICRnbF9nY2Nfd2FybmluZ3Mg PSB5ZXNdLAogICAgIFtnbF9XQVJOX0FERChbLVdlcnJvcl0sIFtXRVJST1JfQ0ZMQUdTXSld KQogICBBQ19TVUJTVChbV0VSUk9SX0NGTEFHU10pCiAKQEAgLTIwMTEsMTcgKzIwMzgsNiBA QCBBQ19ERUZVTgogIyMgJHdpbmRvd19zeXN0ZW0gaXMgbm93IHNldCB0byB0aGUgd2luZG93 IHN5c3RlbSB3ZSB3aWxsCiAjIyB1bHRpbWF0ZWx5IHVzZS4KIAotaWYgdGVzdCAiJHdpbmRv d19zeXN0ZW0iID0gbm9uZSAmJiB0ZXN0ICIkZ2xfZ2NjX3dhcm5pbmdzIiA9IHllczsgdGhl bgotICAgIyBUb28gbWFueSB3YXJuaW5ncyBmb3Igbm93LgotICAgbnc9Ci0gICBudz0iJG53 IC1Xc3VnZ2VzdC1hdHRyaWJ1dGU9bm9yZXR1cm4iCi0gICBnbF9NQU5ZV0FSTl9DT01QTEVN RU5UKFtXQVJOX0NGTEFHU10sIFskV0FSTl9DRkxBR1NdLCBbJG53XSkKLQotICAgZ2xfV0FS Tl9BREQoWy1Xbm8tdW51c2VkLXZhcmlhYmxlXSkKLSAgIGdsX1dBUk5fQUREKFstV25vLXVu dXNlZC1idXQtc2V0LXZhcmlhYmxlXSkKLSAgIGdsX1dBUk5fQUREKFstV25vLXVudXNlZC1i dXQtc2V0LXBhcmFtZXRlcl0pCi1maQotCiB0ZXJtX2hlYWRlcj0KIEhBVkVfWF9XSU5ET1dT PW5vCiBIQVZFX1gxMT1ubwpkaWZmIC0tZ2l0IGEvZXRjL05FV1MgYi9ldGMvTkVXUwppbmRl eCA2Y2MxYzVhLi5kMzhiYzNkIDEwMDY0NAotLS0gYS9ldGMvTkVXUworKysgYi9ldGMvTkVX UwpAQCAtMjUsNiArMjUsMTIgQEAgb3RoZXJ3aXNlIGxlYXZlIGl0IHVubWFya2VkLgogDAog KiBJbnN0YWxsYXRpb24gQ2hhbmdlcyBpbiBFbWFjcyAyNS4yCiAKKyoqIFRoZSBuZXcgb3B0 aW9uICdjb25maWd1cmUgLS1lbmFibGUtZ2NjLXdhcm5pbmdzPXdhcm4tb25seScgY2F1c2Vz CitHQ0MgdG8gaXNzdWUgd2FybmluZ3Mgd2l0aG91dCBzdG9wcGluZyB0aGUgYmlsZC4gIFRo aXMgYmVoYXZpb3IgaXMgbm93Cit0aGUgZGVmYXVsdCBpbiBkZXZlbG9wZXIgYnVpbGRzLiAg QXMgYmVmb3JlLCB1c2UKKyctLWRpc2FibGUtZ2NjLXdhcm5pbmdzJyB0byBzdXBwcmVzcyBH Q0MncyB3YXJuaW5ncywgYW5kCisnLS1lbmFibGUtZ2NjLXdhcm5pbmdzJyB0byBzdG9wIHRo ZSBidWlsZCBpZiBHQ0MgaXNzdWVzIHdhcm5pbmdzLgorCiArKysKICoqIE5ldyBjb25maWd1 cmUgb3B0aW9uICctLWRpc2FibGUtYnVpbGQtZGV0YWlscycgYXR0ZW1wdHMgdG8gYnVpbGQg YW4KIEVtYWNzIHRoYXQgaXMgbW9yZSBsaWtlbHkgdG8gYmUgcmVwcm9kdWNpYmxlOyB0aGF0 IGlzLCBpZiB5b3UgYnVpbGQKLS0gCjIuNS41Cgo= --------------040404090500010003070302--