From: Paul Eggert <eggert@cs.ucla.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org, somasis@exherbo.org, somasissounds@gmail.com
Subject: Re: [PATCH] src/print.c: Check for __GLIBC__ rather than GNU_LINUX
Date: Sun, 3 Apr 2016 01:24:51 -0700 [thread overview]
Message-ID: <5700D353.40107@cs.ucla.edu> (raw)
In-Reply-To: <83pou8s90i.fsf@gnu.org>
Eli Zaretskii wrote:
> Are we sure fileno(stdin) will necessarily return 0, what with all the
> redirections and stuff?
Yes. The redirections in Emacs don't change the file descriptor numbers
associated with stdin, stdout, and stderr. They will always be 0, 1, and 2.
> Why not keep the original code?
It's a bit slower, and (more important) it leads the reader to wonder whether
fileno (stdin) might not equal STDIN_FILENO.
next prev parent reply other threads:[~2016-04-03 8:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 5:22 [PATCH] src/print.c: Check for __GLIBC__ rather than GNU_LINUX Kylie McClain
2016-03-31 20:37 ` Paul Eggert
2016-03-31 21:26 ` Kylie McClain
2016-04-01 6:43 ` Eli Zaretskii
2016-04-01 7:46 ` Paul Eggert
2016-04-02 8:35 ` Eli Zaretskii
2016-04-03 8:24 ` Paul Eggert [this message]
2016-04-04 16:45 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5700D353.40107@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=somasis@exherbo.org \
--cc=somasissounds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).