unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: stefankangas@gmail.com, emacs-devel@gnu.org
Subject: Re: master bdb13a0e5c5 1/2: Adjust to Gnulib’s recent module renaming
Date: Thu, 2 Jan 2025 13:15:51 -0800	[thread overview]
Message-ID: <56f525ed-4540-4fd8-b563-7ea1fbd65064@cs.ucla.edu> (raw)
In-Reply-To: <86ldvthsaq.fsf@gnu.org>

On 2025-01-02 12:30, Eli Zaretskii wrote:

>> I don't see a nontrivial way to update nt/gnulib-cfg.mk automatically,
>> even just for module renames as Eli suggested, as there are too many
>> possibilities for screwups.
> 
> Can you elaborate on that?  I only meant to edit the
> OMIT_GNULIB_MODULE_* settings when a module gets renamed, nothing
> else.

Oh, I meant only that module names are idiosyncratic, and some are 
substrings of others, and it's a bit of a pain to get the substitutions 
exactly right.

It could be done, but it's not worth the effort. As far as I can 
remember this is the first module renaming to affect Emacs since 
lib/gnulib.mk.in was introduced in 2017. Such a problem is in the noise 
compared, to ...


>> In the meantime, module renames are rare enough that doing things by
>> hand should take less work overall. Besides, the main problem here is
>> changes to modules and/or adding modules, which I don't think
>> admin/merge-gnulib can handle by itself.
> 
> Yes, all the other changes cannot be automated.

... this one.


> Gnulib is a general-purpose library, so it cannot use some of
> the enhanced functionality we use in Emacs because we have intimate
> knowledge of what Emacs needs and which functionalities it actually
> uses.  For example, the emulation of pselect is tightly coupled to
> what Emacs uses it for.

That's understandable, and I wasn't suggesting that we migrate all of 
Emacs's stuff into Gnulib. All I was thinking is that Emacs could use 
lib/config.mk.in unchanged, even when Emacs is being built on 
MS-Windows. (Admittedly this is not a project I could help much with.)



  reply	other threads:[~2025-01-02 21:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <mailman.2001.1735773573.32144.emacs-diffs@gnu.org>
2025-01-02 17:30 ` master bdb13a0e5c5 1/2: Adjust to Gnulib’s recent module renaming Eli Zaretskii
2025-01-02 17:57   ` Stefan Kangas
2025-01-02 19:38     ` Paul Eggert
2025-01-02 20:30       ` Eli Zaretskii
2025-01-02 21:15         ` Paul Eggert [this message]
2025-01-03  6:42           ` Eli Zaretskii
2025-01-03 19:06             ` Paul Eggert
2025-01-03 20:01               ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56f525ed-4540-4fd8-b563-7ea1fbd65064@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).