From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Konstantin Kharlamov Newsgroups: gmane.emacs.devel Subject: Re: Adding git-commit highlight mode? Date: Sat, 04 Jan 2025 01:52:45 +0300 Message-ID: <56c9eadd95367cd3fd7c8414dc3e86b243a4b3d7.camel@yandex.ru> References: <37733be4476e1c2b6e873c967c79cb0035959a9e.camel@yandex.ru> <083310b3-a288-5c75-c835-84595e134682@gmail.com> <87r05jbnw2.fsf@> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16993"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Evolution 3.54.2 Cc: emacs-devel@gnu.org, Jonas Bernoulli To: =?ISO-8859-1?Q?Bj=F6rn?= Bidar , Jim Porter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jan 03 23:53:52 2025 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tTqYC-0004Gm-0Q for ged-emacs-devel@m.gmane-mx.org; Fri, 03 Jan 2025 23:53:52 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tTqXR-0004Iy-CP; Fri, 03 Jan 2025 17:53:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tTqXM-0004Ie-Gq for emacs-devel@gnu.org; Fri, 03 Jan 2025 17:53:00 -0500 Original-Received: from forward501a.mail.yandex.net ([178.154.239.81]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tTqXI-0003i8-0j for emacs-devel@gnu.org; Fri, 03 Jan 2025 17:53:00 -0500 Original-Received: from mail-nwsmtp-smtp-production-main-52.vla.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-52.vla.yp-c.yandex.net [IPv6:2a02:6b8:c0d:9:0:640:2d51:0]) by forward501a.mail.yandex.net (Yandex) with ESMTPS id 39E4960E88; Sat, 4 Jan 2025 01:52:48 +0300 (MSK) Original-Received: by mail-nwsmtp-smtp-production-main-52.vla.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id kqq8o8JOniE0-EUfXNX9u; Sat, 04 Jan 2025 01:52:47 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1735944767; bh=2k11JdVo0J2BPRCD0wCeaBImtsMHK7898g6GoN9G4KM=; h=References:Date:In-Reply-To:Cc:To:From:Subject:Message-ID; b=X2md9CPfz7mSiv+J2TI2PnJvfnciumn4TJP3zeP6EPn04GCpX1mgMOIHhPuM/OTnI l73Wwz+WFzRCI/URBue6esb7PQsAFcKl6Esq7O8ggrsOASjwIy70SQ8bndvN1vhy/K qt6Bd6gZWh2d0GPqPS6TuhTUjxaJxf97TloymVVU= Authentication-Results: mail-nwsmtp-smtp-production-main-52.vla.yp-c.yandex.net; dkim=pass header.i=@yandex.ru In-Reply-To: <87r05jbnw2.fsf@> Received-SPF: pass client-ip=178.154.239.81; envelope-from=Hi-Angel@yandex.ru; helo=forward501a.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:327639 Archived-At: On Fri, 2025-01-03 at 23:14 +0200, Bj=C3=B6rn Bidar wrote: > Jim Porter writes: >=20 > > On 1/2/2025 10:30 AM, Konstantin Kharlamov wrote: > > > But Emacs seems to be the only widely popular editor that still > > > doesn't > > > provide OOTB at least syntax highlight for git-commit format. So, > > > does > > > anyone have opposition to adding a major mode that would be bound > > > to > > > filenames like `COMMIT_EDITMSG` and others, and would provide the > > > aforementioned highlight? > >=20 > > For what it's worth, I wrote a very simple package to do this for > > myself, since I don't use Magit. (I'm just so used to the Git > > command > > line that I've never taken the time to mess with Magit.) > >=20 >=20 > Is there a way we can do this without reinventing the wheel? E.g. by > including Jonas's git-commit mode into Emacs? Using Jim's mode comes as close as it gets to not reinventing the wheel. As mentioned by Stefan elsewhere in the thread, Jonas' git- commit that is part of magit can't be easily included for license reasons. > PS: It would be very beneficial to not uses Github for Emacs > development but other FOSS platforms such as Codeberg. No need to > feed > Copilot with our code to copy it into other non-FOSS code. As mentioned by Dick, Emacs is mirrored to Github anyway. From my search it seems neither Codeberg nor Gitlab has an active Emacs mirror, right? That means there's no other option besides Github for contributors to store their local changes to before sending them upstream. Obviously, a new contributor wouldn't have an account to git.savannah, and even if they do, git.savannah doesn't allow to fork a repo, instead it requires to store everyone the changes to their local branch on a shared repo, which seems unsafe on a bigger scale.