From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: make-xwidget api change patch Date: Sun, 27 Mar 2016 13:37:48 -0700 Organization: UCLA Computer Science Department Message-ID: <56F8449C.2090806@cs.ucla.edu> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------010508080604090906070406" X-Trace: ger.gmane.org 1459111093 29445 80.91.229.3 (27 Mar 2016 20:38:13 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 27 Mar 2016 20:38:13 +0000 (UTC) To: joakim@verona.se, Emacs developers , Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 27 22:38:04 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1akHRj-0003zA-S0 for ged-emacs-devel@m.gmane.org; Sun, 27 Mar 2016 22:38:04 +0200 Original-Received: from localhost ([::1]:37347 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akHRf-0007nr-GM for ged-emacs-devel@m.gmane.org; Sun, 27 Mar 2016 16:37:59 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52896) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akHRc-0007ni-0J for emacs-devel@gnu.org; Sun, 27 Mar 2016 16:37:56 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1akHRb-0008D7-5d for emacs-devel@gnu.org; Sun, 27 Mar 2016 16:37:55 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:49386) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akHRX-0008CV-9a; Sun, 27 Mar 2016 16:37:51 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id BD7DF160D7D; Sun, 27 Mar 2016 13:37:49 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id lKRVPqbIy8BA; Sun, 27 Mar 2016 13:37:49 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 236D1161244; Sun, 27 Mar 2016 13:37:49 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id v2baj8FaheLn; Sun, 27 Mar 2016 13:37:49 -0700 (PDT) Original-Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 06B9A160D7D; Sun, 27 Mar 2016 13:37:49 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:202302 Archived-At: This is a multi-part message in MIME format. --------------010508080604090906070406 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit I also think this change should go in. I never understood what those two parameters were for anyway. Some further tweaks appear to be needed, though; please see the attached patch. --------------010508080604090906070406 Content-Type: application/x-patch; name="0001-make-xwidget-unused-arg-cleanup.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-make-xwidget-unused-arg-cleanup.patch" RnJvbSA1ODdiMjQxNzk5NjYyMDY1YzMyM2Q5ODFjMWExNTY5ZjNjNDk5NWUyIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBTdW4sIDI3IE1hciAyMDE2IDEzOjM2OjE4IC0wNzAwClN1YmplY3Q6IFtQQVRD SF0gbWFrZS14d2lkZ2V0IHVudXNlZCBhcmcgY2xlYW51cAoKKiBkb2MvbGlzcHJlZi9kaXNw bGF5LnRleGkgKFh3aWRnZXRzKTogUmVtb3ZlIHN0cmF5IHJlZnMuCiogc3JjL3h3aWRnZXQu YyAoc3ltc19vZl94d2lkZ2V0KTogUXdlYmtpdCwgbm90IFF3ZWJraXRfb3NyLgotLS0KIGRv Yy9saXNwcmVmL2Rpc3BsYXkudGV4aSB8ICA1ICsrLS0tCiBzcmMveHdpZGdldC5jICAgICAg ICAgICAgfCAxNCArKysrKysrLS0tLS0tLQogMiBmaWxlcyBjaGFuZ2VkLCA5IGluc2VydGlv bnMoKyksIDEwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RvYy9saXNwcmVmL2Rpc3Bs YXkudGV4aSBiL2RvYy9saXNwcmVmL2Rpc3BsYXkudGV4aQppbmRleCAzMzc3MjUyLi4xZTQ1 NTAxIDEwMDY0NAotLS0gYS9kb2MvbGlzcHJlZi9kaXNwbGF5LnRleGkKKysrIGIvZG9jL2xp c3ByZWYvZGlzcGxheS50ZXhpCkBAIC01ODA1LDggKzU4MDUsNyBAQCBYd2lkZ2V0cwogUHJv cGVydHl9KS4KIAogQGRlZnVuIG1ha2UteHdpZGdldCB0eXBlIHRpdGxlIHdpZHRoIGhlaWdo dCBhcmd1bWVudHMgJm9wdGlvbmFsIGJ1ZmZlcgotVGhpcyBjcmVhdGVzIGFuIHh3aWRnZXQg b2JqZWN0IGJldHdlZW4gQHZhcntiZWd9IGFuZCBAdmFye2VuZH0sIGJ1ZmZlcgotcG9zaXRp b25zIGluIEB2YXJ7YnVmZmVyfSwgYW5kIHJldHVybnMgdGhlIG5ldyBvYmplY3QuICBJZgor VGhpcyBjcmVhdGVzIGFuZCByZXR1cm5zIGFuIHh3aWRnZXQgb2JqZWN0LiAgSWYKIEB2YXJ7 YnVmZmVyfSBpcyBvbWl0dGVkIG9yIEBjb2Rle25pbH0sIGl0IGRlZmF1bHRzIHRvIHRoZSBj dXJyZW50CiBidWZmZXIuICBJZiBAdmFye2J1ZmZlcn0gbmFtZXMgYSBidWZmZXIgdGhhdCBk b2Vzbid0IGV4aXN0LCBpdCB3aWxsIGJlCiBjcmVhdGVkLiAgVGhlIEB2YXJ7dHlwZX0gaWRl bnRpZmllcyB0aGUgdHlwZSBvZiB0aGUgeHdpZGdldCBjb21wb25lbnQsCkBAIC01ODE0LDcg KzU4MTMsNyBAQCBYd2lkZ2V0cwogCiBAdGFibGUgQGNvZGUKIEBpdGVtIHdlYmtpdAotVGhl IFdlYktpdCAoQGRmbntvbi1zdGFjayByZXBsYWNlbWVudH0pIGNvbXBvbmVudC4KK1RoZSBX ZWJLaXQgY29tcG9uZW50LgogQGVuZCB0YWJsZQogCiBUaGUgQHZhcnt3aWR0aH0gYW5kIEB2 YXJ7aGVpZ2h0fSBhcmd1bWVudHMgc3BlY2lmeSB0aGUgd2lkZ2V0IHNpemUgaW4KZGlmZiAt LWdpdCBhL3NyYy94d2lkZ2V0LmMgYi9zcmMveHdpZGdldC5jCmluZGV4IDFhMTI1ODMuLjU4 ODM1ZjMgMTAwNjQ0Ci0tLSBhL3NyYy94d2lkZ2V0LmMKKysrIGIvc3JjL3h3aWRnZXQuYwpA QCAtMTg3LDcgKzE4Nyw3IEBAIFJldHVybnMgdGhlIG5ld2x5IGNvbnN0cnVjdGVkIHh3aWRn ZXQsIG9yIG5pbCBpZiBjb25zdHJ1Y3Rpb24gZmFpbHMuICAqLykKICAgeHctPndpZGdldF9v c3IgPSBOVUxMOwogICB4dy0+cGxpc3QgPSBRbmlsOwogCi0gIGlmIChFUSAoeHctPnR5cGUs IFF3ZWJraXRfb3NyKSkKKyAgaWYgKEVRICh4dy0+dHlwZSwgUXdlYmtpdCkpCiAgICAgewog ICAgICAgYmxvY2tfaW5wdXQgKCk7CiAgICAgICB4dy0+d2lkZ2V0d2luZG93X29zciA9IGd0 a19vZmZzY3JlZW5fd2luZG93X25ldyAoKTsKQEAgLTE5Nyw3ICsxOTcsNyBAQCBSZXR1cm5z IHRoZSBuZXdseSBjb25zdHJ1Y3RlZCB4d2lkZ2V0LCBvciBuaWwgaWYgY29uc3RydWN0aW9u IGZhaWxzLiAgKi8pCiAgICAgICAvKiBXZWJLaXQgT1NSIGlzIHRoZSBvbmx5IHNjcm9sbGVk IGNvbXBvbmVudCBhdCB0aGUgbW9tZW50LiAgKi8KICAgICAgIHh3LT53aWRnZXRzY3JvbGxl ZHdpbmRvd19vc3IgPSBOVUxMOwogCi0gICAgICBpZiAoRVEgKHh3LT50eXBlLCBRd2Via2l0 X29zcikpCisgICAgICBpZiAoRVEgKHh3LT50eXBlLCBRd2Via2l0KSkKICAgICAgICAgewog ICAgICAgICAgIHh3LT53aWRnZXRzY3JvbGxlZHdpbmRvd19vc3IgPSBndGtfc2Nyb2xsZWRf d2luZG93X25ldyAoTlVMTCwgTlVMTCk7CiAgICAgICAgICAgZ3RrX3Njcm9sbGVkX3dpbmRv d19zZXRfbWluX2NvbnRlbnRfaGVpZ2h0CkBAIC0yMTgsNyArMjE4LDcgQEAgUmV0dXJucyB0 aGUgbmV3bHkgY29uc3RydWN0ZWQgeHdpZGdldCwgb3IgbmlsIGlmIGNvbnN0cnVjdGlvbiBm YWlscy4gICovKQogICAgICAgZ3RrX3dpZGdldF9zZXRfc2l6ZV9yZXF1ZXN0IChHVEtfV0lE R0VUICh4dy0+d2lkZ2V0X29zciksIHh3LT53aWR0aCwKICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgeHctPmhlaWdodCk7CiAKLSAgICAgIGlmIChFUSAoeHctPnR5cGUs IFF3ZWJraXRfb3NyKSkKKyAgICAgIGlmIChFUSAoeHctPnR5cGUsIFF3ZWJraXQpKQogICAg ICAgICB7CiAgICAgICAgICAgZ3RrX2NvbnRhaW5lcl9hZGQgKEdUS19DT05UQUlORVIgKHh3 LT53aWRnZXR3aW5kb3dfb3NyKSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgeHct PndpZGdldHNjcm9sbGVkd2luZG93X29zcik7CkBAIC0yMzksNyArMjM5LDcgQEAgUmV0dXJu cyB0aGUgbmV3bHkgY29uc3RydWN0ZWQgeHdpZGdldCwgb3IgbmlsIGlmIGNvbnN0cnVjdGlv biBmYWlscy4gICovKQogICAgICAgZ19vYmplY3Rfc2V0X2RhdGEgKEdfT0JKRUNUICh4dy0+ d2lkZ2V0d2luZG93X29zciksIFhHX1hXSURHRVQsIHh3KTsKIAogICAgICAgLyogc2lnbmFs cyAqLwotICAgICAgaWYgKEVRICh4dy0+dHlwZSwgUXdlYmtpdF9vc3IpKQorICAgICAgaWYg KEVRICh4dy0+dHlwZSwgUXdlYmtpdCkpCiAgICAgICAgIHsKICAgICAgICAgICBnX3NpZ25h bF9jb25uZWN0IChHX09CSkVDVCAoeHctPndpZGdldF9vc3IpLAogICAgICAgICAgICAgICAg ICAgICAgICAgICAgICJkb2N1bWVudC1sb2FkLWZpbmlzaGVkIiwKQEAgLTQ5Nyw3ICs0OTcs NyBAQCB4d2lkZ2V0X2luaXRfdmlldyAoc3RydWN0IHh3aWRnZXQgKnh3dywKICAgWFNFVFdJ TkRPVyAoeHYtPncsIHMtPncpOwogICBYU0VUWFdJREdFVCAoeHYtPm1vZGVsLCB4d3cpOwog Ci0gIGlmIChFUSAoeHd3LT50eXBlLCBRd2Via2l0X29zcikpCisgIGlmIChFUSAoeHd3LT50 eXBlLCBRd2Via2l0KSkKICAgICB7CiAgICAgICB4di0+d2lkZ2V0ID0gZ3RrX2RyYXdpbmdf YXJlYV9uZXcgKCk7CiAgICAgICAvKiBFeHBvc2UgZXZlbnQgaGFuZGxpbmcuICAqLwpAQCAt NTA4LDcgKzUwOCw3IEBAIHh3aWRnZXRfaW5pdF92aWV3IChzdHJ1Y3QgeHdpZGdldCAqeHd3 LAogICAgICAgZ19zaWduYWxfY29ubmVjdCAoR19PQkpFQ1QgKHh3dy0+d2lkZ2V0d2luZG93 X29zciksICJkYW1hZ2UtZXZlbnQiLAogICAgICAgICAgICAgICAgICAgICAgICAgR19DQUxM QkFDSyAob2Zmc2NyZWVuX2RhbWFnZV9ldmVudCksIHh2LT53aWRnZXQpOwogCi0gICAgICBp ZiAoRVEgKHh3dy0+dHlwZSwgUXdlYmtpdF9vc3IpKQorICAgICAgaWYgKEVRICh4d3ctPnR5 cGUsIFF3ZWJraXQpKQogICAgICAgICB7CiAgICAgICAgICAgZ19zaWduYWxfY29ubmVjdCAo R19PQkpFQ1QgKHh2LT53aWRnZXQpLCAiYnV0dG9uLXByZXNzLWV2ZW50IiwKICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBHX0NBTExCQUNLICh4d2lkZ2V0X29zcl9ldmVudF9mb3J3 YXJkKSwgTlVMTCk7CkBAIC05ODMsNyArOTgzLDcgQEAgc3ltc19vZl94d2lkZ2V0ICh2b2lk KQogICBkZWZzdWJyICgmU3h3aWRnZXRfd2Via2l0X2dvdG9fdXJpKTsKICAgZGVmc3ViciAo JlN4d2lkZ2V0X3dlYmtpdF9leGVjdXRlX3NjcmlwdCk7CiAgIGRlZnN1YnIgKCZTeHdpZGdl dF93ZWJraXRfZ2V0X3RpdGxlKTsKLSAgREVGU1lNIChRd2Via2l0X29zciwgIndlYmtpdCIp OworICBERUZTWU0gKFF3ZWJraXQsICJ3ZWJraXQiKTsKIAogICBkZWZzdWJyICgmU3h3aWRn ZXRfc2l6ZV9yZXF1ZXN0KTsKICAgZGVmc3ViciAoJlNkZWxldGVfeHdpZGdldF92aWV3KTsK LS0gCjIuNS41Cgo= --------------010508080604090906070406--