unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: Glenn Morris <rgm@gnu.org>, emacs-devel@gnu.org
Subject: Re: master b082371: Change do-not-merge pattern to "do not merge"
Date: Tue, 22 Mar 2016 16:50:38 -0700	[thread overview]
Message-ID: <56F1DA4E.40709@cs.ucla.edu> (raw)
In-Reply-To: <ffy49agnb1.fsf@fencepost.gnu.org>

On 03/22/2016 03:28 PM, Glenn Morris wrote:
> Should also include "don't merge", "no need to merge",
> etc. (Unless you think you can get Emacs developers to follow a
> convention, which history suggests is unlikely.)
I added "no need to merge".  As "don't merge" is typically a false alarm 
(of its six occurrences in the emacs-25 log, five are false alarms), I 
left it out. Let's try to stick with "do not merge" or "no need to 
merge" in future commit messages of this type.

> This pattern needs to
> err on the side of false positives rather than false negatives

Unfortunately it's not that simple. As we've seen, applied false 
positives cause patches to be lost, an error that is unlikely to be 
caught when others review the merge, and some of these errors lurked in 
'master' for over two months. In contrast, applied false negatives cause 
wrong patches to be added, which is much more likely to be caught right 
away on review. So although it makes sense for other reasons to err on 
the side of false negatives, our thumbs shouldn't press too hard on the 
scale.



      reply	other threads:[~2016-03-22 23:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20160322195727.22320.53641@vcs.savannah.gnu.org>
     [not found] ` <E1aiSQh-0005od-V6@vcs.savannah.gnu.org>
2016-03-22 22:28   ` master b082371: Change do-not-merge pattern to "do not merge" Glenn Morris
2016-03-22 23:50     ` Paul Eggert [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56F1DA4E.40709@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=emacs-devel@gnu.org \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).