From: "Andreas Röhler" <andreas.roehler@online.de>
To: emacs-devel@gnu.org
Subject: Re: Syntax tables for multiple modes [was: bug#22983: syntax-ppss returns wrong result.]
Date: Mon, 21 Mar 2016 08:13:17 +0100 [thread overview]
Message-ID: <56EF9F0D.8040600@online.de> (raw)
In-Reply-To: <87twk0beuh.fsf@gmail.com>
On 21.03.2016 06:05, Vitalie Spinu wrote:
>
>>> On Sun, Mar 20 2016 23:11, Stefan Monnier wrote:
>>> BTW, I parse-partial-sexp must abide hard-widen-limits as well.
>> I don't understand what this means. parse-partial-sexp is passed
>> 2 locations and it works between them. There's not much opportunity
>> for widening.
> parse-partial-sexp should work between hard limits (at least the lower
> bound). It should operate as if hard-narrowed buffer is the real buffer.
>
> So ideally it should take (max FROM (car hard-widen-limits)) as the starting
> position. This will give the desired consistency between parse-partial-sexp and
> syntax-ppss with the price of slightly modifying the semantics of
> parse-partial-sexp in a backward compatible way.
>
>>> A patch that would require hunting every single mode out there and
>>> implementing multi-modes locally should have been more carefully
>>> considered IMO.
>> I must say I don't understand how what we have is so very different from
>> what you suggest.
> It's quite a bit different:
>
> - Major mode authors won't need to know about multi-modes. That means not
> dealing with chunks/spans/headers etc. These concepts are not even uniformly
> defined between existing multi-mode engines.
>
> - Major mode authors won't need to re-implement the indentation logic already
> there in multi-modes. The logic is likely to be too simplistic and major
> mode authors will have to re-do it anyways.
>
> - Setup is more general. multi-mode engine decides where to call
> calculate-indent-function and with what parameters and with what narrowing.
>
> - Arguably calculate-indent-function is a simpler concept to grasp
>
> - calculate-indent-function is needed anyways
>
>> I think both suggestions require changes to every mode, and in both cases the
>> changes can be reduced to a one-liner or close enough (for the simple
>> case). Admittedly, for it to be a one-liner, we'll need to provide a standard
>> helper function.
> Judging from python.el it might be quite hard to provide a generic one liner to
> deal with all those 3 elements. For calculate-indent-function instead you can
> provide a straightforward one line assuming that STRING-BEFORE/AFTER do not
> matter.
>
>
> Vitalie
>
+1
next prev parent reply other threads:[~2016-03-21 7:13 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160311151512.GD2888@acm.fritz.box>
[not found] ` <b158555f-e014-ed7b-23eb-d80d2d77a6f4@yandex.ru>
[not found] ` <20160311212410.GG2888@acm.fritz.box>
[not found] ` <73903215-f94b-e194-7bfe-0d6350c95769@yandex.ru>
[not found] ` <20160311221540.GH2888@acm.fritz.box>
[not found] ` <2c301ec9-041d-9172-d628-479062314b23@yandex.ru>
2016-03-14 15:16 ` Syntax tables for multiple modes [was: bug#22983: syntax-ppss returns wrong result.] Alan Mackenzie
2016-03-14 17:34 ` Andreas Röhler
2016-03-14 20:06 ` Dmitry Gutov
2016-03-19 22:51 ` Vitalie Spinu
2016-03-20 2:19 ` Dmitry Gutov
2016-03-20 12:15 ` Vitalie Spinu
2016-03-20 15:58 ` Dmitry Gutov
2016-03-21 1:05 ` Vitalie Spinu
2016-03-21 3:11 ` Stefan Monnier
2016-03-21 5:05 ` Vitalie Spinu
2016-03-21 7:13 ` Andreas Röhler [this message]
2016-03-21 12:26 ` Stefan Monnier
2016-03-21 14:13 ` Vitalie Spinu
2016-03-21 14:43 ` Stefan Monnier
2016-03-21 16:42 ` Vitalie Spinu
2016-03-21 18:31 ` Stefan Monnier
2016-03-21 19:16 ` Vitalie Spinu
2016-03-21 20:47 ` Stefan Monnier
2016-03-21 20:33 ` Alan Mackenzie
2016-03-21 20:49 ` Stefan Monnier
2016-03-21 21:03 ` Drew Adams
2016-03-21 21:12 ` Dmitry Gutov
2016-03-21 16:45 ` Vitalie Spinu
2016-03-21 22:55 ` Dmitry Gutov
2016-03-22 14:51 ` Stefan Monnier
2016-03-22 18:17 ` Vitalie Spinu
2016-03-23 1:18 ` Dmitry Gutov
2016-03-23 13:18 ` Stefan Monnier
2016-03-22 18:26 ` Vitalie Spinu
2016-03-23 2:07 ` Stefan Monnier
2016-03-23 10:56 ` Vitalie Spinu
2016-03-23 11:41 ` Stefan Monnier
2016-03-23 12:39 ` Vitalie Spinu
2016-03-23 13:23 ` Stefan Monnier
2016-03-23 15:28 ` Dmitry Gutov
2016-03-23 21:51 ` Vitalie Spinu
2016-03-24 7:30 ` Andreas Röhler
2016-03-21 11:56 ` Dmitry Gutov
2016-03-21 5:08 ` [Patch] hard-widen-limits [was Re: Syntax tables for multiple modes [was: bug#22983: syntax-ppss returns wrong result.]] Vitalie Spinu
2016-03-21 12:39 ` Stefan Monnier
2016-03-21 12:54 ` Vitalie Spinu
2016-03-21 14:07 ` Stefan Monnier
2016-03-21 14:14 ` Vitalie Spinu
2016-03-21 14:04 ` Stefan Monnier
2016-03-21 14:33 ` Vitalie Spinu
2016-03-21 14:54 ` Stefan Monnier
2016-03-21 17:16 ` Vitalie Spinu
2016-03-21 18:36 ` Stefan Monnier
2016-03-21 19:18 ` Vitalie Spinu
2016-03-22 3:17 ` Vitalie Spinu
2016-03-22 9:57 ` Vitalie Spinu
2016-03-22 10:05 ` Vitalie Spinu
2016-03-22 11:57 ` Stefan Monnier
2016-03-22 16:28 ` Vitalie Spinu
2016-03-22 16:44 ` Stefan Monnier
2016-03-22 19:36 ` Vitalie Spinu
2016-03-23 2:22 ` Stefan Monnier
2016-03-23 11:41 ` Vitalie Spinu
2016-03-23 12:34 ` Stefan Monnier
2016-03-23 12:41 ` Vitalie Spinu
2016-03-29 21:43 ` Vitalie Spinu
2016-04-22 14:34 ` Dmitry Gutov
2016-04-24 7:22 ` Vitalie Spinu
2016-04-24 7:28 ` Achim Gratz
2016-04-24 11:33 ` Vitalie Spinu
2016-04-24 13:20 ` Andreas Schwab
2016-04-24 16:11 ` Vitalie Spinu
2016-04-24 16:19 ` Andreas Schwab
2016-04-24 16:41 ` Vitalie Spinu
2016-04-24 16:48 ` Andreas Schwab
2016-04-24 18:01 ` Vitalie Spinu
2016-04-24 19:05 ` Andreas Schwab
2016-04-28 13:29 ` Vitalie Spinu
2016-04-30 14:06 ` Stefan Monnier
2016-03-22 20:08 ` Richard Stallman
2016-03-22 22:45 ` Vitalie Spinu
2016-03-21 11:47 ` Syntax tables for multiple modes [was: bug#22983: syntax-ppss returns wrong result.] Dmitry Gutov
2016-03-21 12:40 ` Vitalie Spinu
2016-03-21 13:07 ` Dmitry Gutov
2016-03-21 14:20 ` Vitalie Spinu
2016-03-21 14:29 ` Dmitry Gutov
2016-03-21 14:42 ` Vitalie Spinu
2016-03-21 14:56 ` Dmitry Gutov
2016-03-21 16:52 ` Vitalie Spinu
2016-03-21 21:30 ` Dmitry Gutov
2016-04-03 23:34 ` John Wiegley
2016-03-21 14:02 ` Stefan Monnier
2016-03-21 14:31 ` Vitalie Spinu
2016-03-21 15:06 ` Stefan Monnier
2016-03-21 17:15 ` Andreas Röhler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56EF9F0D.8040600@online.de \
--to=andreas.roehler@online.de \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).