Re: master 9aa18659263: Fix c-ts-common-comment-indent-new-line (bug#73900)

Re: master 9aa18659263: Fix c-ts-common-comment-indent-new-line (bug#73900)

[Eli Zaretskii]

> branch: master
> commit 9aa186592634212fcdb2dbafdfd0c52a2475ba96
> Author: Yuan Fu <casouri@gmail.com>
> Commit: Yuan Fu <casouri@gmail.com>
> 
>     Fix c-ts-common-comment-indent-new-line (bug#73900)
>     
>     * lisp/progmodes/c-ts-common.el:
>     (c-ts-common-comment-indent-new-line): Delete trailing
>     whitespace before inserting newline.  The insert-line-break
>     function is the same as in c-indent-new-comment-line.

This triggers the following byte-compilation warning:

  In c-ts-common-comment-indent-new-line:
  progmodes/c-ts-common.el:339:27: Warning: reference to free variable `allow-auto-fill'

I'm guessing that in c-ts-mode case allow-auto-fill is always nil.

Re: master 9aa18659263: Fix c-ts-common-comment-indent-new-line (bug#73900)

[Andrea Corallo]

Yuan Fu <casouri@gmail.com> writes:

> branch: master
> commit 9aa186592634212fcdb2dbafdfd0c52a2475ba96
> Author: Yuan Fu <casouri@gmail.com>
> Commit: Yuan Fu <casouri@gmail.com>
>
>     Fix c-ts-common-comment-indent-new-line (bug#73900)
>     
>     * lisp/progmodes/c-ts-common.el:
>     (c-ts-common-comment-indent-new-line): Delete trailing
>     whitespace before inserting newline.  The insert-line-break
>     function is the same as in c-indent-new-comment-line.
> ---
>  lisp/progmodes/c-ts-common.el | 104 ++++++++++++++++++++++--------------------
>  1 file changed, 55 insertions(+), 49 deletions(-)

Hi Yuan,

I believe this is introducing the following building master:

progmodes/c-ts-common.el:339:27: Warning: reference to free variable ‘allow-auto-fill’

IIUC some code was imported in 'c-ts-common-comment-indent-new-line'
from 'c-indent-new-comment-line' but in the latter the interface
includes the 'allow-auto-fill' optional parameter.

Would you mind having a look?

Please always check that the build is clean before installing a change.

Thanks

  Andrea

Re: master 9aa18659263: Fix c-ts-common-comment-indent-new-line (bug#73900)

[Yuan Fu]

> On Oct 30, 2024, at 7:17 AM, Andrea Corallo <acorallo@gnu.org> wrote:
> 
> Yuan Fu <casouri@gmail.com> writes:
> 
>> branch: master
>> commit 9aa186592634212fcdb2dbafdfd0c52a2475ba96
>> Author: Yuan Fu <casouri@gmail.com>
>> Commit: Yuan Fu <casouri@gmail.com>
>> 
>>    Fix c-ts-common-comment-indent-new-line (bug#73900)
>> 
>>    * lisp/progmodes/c-ts-common.el:
>>    (c-ts-common-comment-indent-new-line): Delete trailing
>>    whitespace before inserting newline.  The insert-line-break
>>    function is the same as in c-indent-new-comment-line.
>> ---
>> lisp/progmodes/c-ts-common.el | 104 ++++++++++++++++++++++--------------------
>> 1 file changed, 55 insertions(+), 49 deletions(-)
> 
> Hi Yuan,
> 
> I believe this is introducing the following building master:
> 
> progmodes/c-ts-common.el:339:27: Warning: reference to free variable ‘allow-auto-fill’
> 
> IIUC some code was imported in 'c-ts-common-comment-indent-new-line'
> from 'c-indent-new-comment-line' but in the latter the interface
> includes the 'allow-auto-fill' optional parameter.
> 
> Would you mind having a look?
> 
> Please always check that the build is clean before installing a change.
> 
> Thanks
> 
>  Andrea

Yes, thanks for the notice. And apologies :( It should be fixed now.

Yuan

Re: master 9aa18659263: Fix c-ts-common-comment-indent-new-line (bug#73900)

[Yuan Fu]

> On Oct 29, 2024, at 5:32 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> 
>> branch: master
>> commit 9aa186592634212fcdb2dbafdfd0c52a2475ba96
>> Author: Yuan Fu <casouri@gmail.com>
>> Commit: Yuan Fu <casouri@gmail.com>
>> 
>>    Fix c-ts-common-comment-indent-new-line (bug#73900)
>> 
>>    * lisp/progmodes/c-ts-common.el:
>>    (c-ts-common-comment-indent-new-line): Delete trailing
>>    whitespace before inserting newline.  The insert-line-break
>>    function is the same as in c-indent-new-comment-line.
> 
> This triggers the following byte-compilation warning:
> 
>  In c-ts-common-comment-indent-new-line:
>  progmodes/c-ts-common.el:339:27: Warning: reference to free variable `allow-auto-fill'
> 
> I'm guessing that in c-ts-mode case allow-auto-fill is always nil.

Thank Eli, I’ve fixed it now. Sorry for the hiccup.

Yuan