From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Recent commits break compilation for MinGW64 Date: Thu, 11 Feb 2016 13:33:39 -0800 Organization: UCLA Computer Science Department Message-ID: <56BCFE33.7080302@cs.ucla.edu> References: <831t8j9e0m.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------080205050607010609040702" X-Trace: ger.gmane.org 1455226440 13204 80.91.229.3 (11 Feb 2016 21:34:00 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 11 Feb 2016 21:34:00 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii , Fabrice Popineau Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 11 22:33:52 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aTys3-0005s7-UO for ged-emacs-devel@m.gmane.org; Thu, 11 Feb 2016 22:33:52 +0100 Original-Received: from localhost ([::1]:53741 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTys3-0001ki-31 for ged-emacs-devel@m.gmane.org; Thu, 11 Feb 2016 16:33:51 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53514) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTyry-0001kU-Q1 for emacs-devel@gnu.org; Thu, 11 Feb 2016 16:33:47 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTyrx-0006QA-RT for emacs-devel@gnu.org; Thu, 11 Feb 2016 16:33:46 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:53694) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTyrt-0006Pl-VG; Thu, 11 Feb 2016 16:33:42 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 279A4160FC1; Thu, 11 Feb 2016 13:33:41 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id fp1Wn8yQA29b; Thu, 11 Feb 2016 13:33:40 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 37258160FBE; Thu, 11 Feb 2016 13:33:40 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id wtO_o9_3shhE; Thu, 11 Feb 2016 13:33:40 -0800 (PST) Original-Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 1CE5B1605F2; Thu, 11 Feb 2016 13:33:40 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 In-Reply-To: <831t8j9e0m.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:199780 Archived-At: This is a multi-part message in MIME format. --------------080205050607010609040702 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 02/11/2016 12:40 PM, Eli Zaretskii wrote: >> From: Fabrice Popineau >> Date: Thu, 11 Feb 2016 07:20:32 +0000 (UTC) >> >> The use of va_start() and consorts >> requires >> #include Sorry about that. Fixed with the attached. On GNU/Linux, lib/stdio.h includes which is why the compile worked for me. > I think such commits shouldn't happen at all on emacs-25, but on > master. IMO, the time for cleanups on the release branch has come and > gone. The overall commit was needed to port to GCC 4.8 and later with -fsanitize=address. In hindsight perhaps I should have stuck with the old non-stdarg API for the newly added diagnostics (on the other hand perhaps not -- the old API was hard to follow and the confusion caused a bug in my first version, which is why I changed it). --------------080205050607010609040702 Content-Type: application/x-patch; name="0001-lib-src-make-docfile.c-Include-stdarg.h.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-lib-src-make-docfile.c-Include-stdarg.h.patch" RnJvbSBiZWQ5ZWI4YjY3ZDhkODQzYTVlNzFmYjcwMGY4MzQ0MmQ4YWU1MzQ5IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBUaHUsIDExIEZlYiAyMDE2IDEyOjUwOjQ4IC0wODAwClN1YmplY3Q6IFtQQVRD SF0gKiBsaWItc3JjL21ha2UtZG9jZmlsZS5jOiBJbmNsdWRlIHN0ZGFyZy5oLgoKLS0tCiBs aWItc3JjL21ha2UtZG9jZmlsZS5jIHwgMSArCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRp b24oKykKCmRpZmYgLS1naXQgYS9saWItc3JjL21ha2UtZG9jZmlsZS5jIGIvbGliLXNyYy9t YWtlLWRvY2ZpbGUuYwppbmRleCAxMjIyMmMzLi5lMjY2MjA3IDEwMDY0NAotLS0gYS9saWIt c3JjL21ha2UtZG9jZmlsZS5jCisrKyBiL2xpYi1zcmMvbWFrZS1kb2NmaWxlLmMKQEAgLTM2 LDYgKzM2LDcgQEAgYWxvbmcgd2l0aCBHTlUgRW1hY3MuICBJZiBub3QsIHNlZSA8aHR0cDov L3d3dy5nbnUub3JnL2xpY2Vuc2VzLz4uICAqLwogCiAjaW5jbHVkZSA8Y29uZmlnLmg+CiAK KyNpbmNsdWRlIDxzdGRhcmcuaD4KICNpbmNsdWRlIDxzdGRib29sLmg+CiAjaW5jbHVkZSA8 c3RkZGVmLmg+CiAjaW5jbHVkZSA8c3RkaW50Lmg+Ci0tIAoyLjUuMAoK --------------080205050607010609040702--