From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daniel Colascione Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master de76a16: Performance improvements for vc-hg Date: Mon, 8 Feb 2016 12:11:46 -0800 Message-ID: <56B8F682.7040404@dancol.org> References: <20160208185311.9470.7389@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Kc6qxoHlsnx4gV134tQLXiwq0puWTG6pA" X-Trace: ger.gmane.org 1454962341 30837 80.91.229.3 (8 Feb 2016 20:12:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 8 Feb 2016 20:12:21 +0000 (UTC) To: Stefan Monnier , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 08 21:12:19 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aSsAV-0005Ku-2u for ged-emacs-devel@m.gmane.org; Mon, 08 Feb 2016 21:12:19 +0100 Original-Received: from localhost ([::1]:48428 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSsAU-0001Be-6A for ged-emacs-devel@m.gmane.org; Mon, 08 Feb 2016 15:12:18 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44357) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSsAD-0001Ao-52 for emacs-devel@gnu.org; Mon, 08 Feb 2016 15:12:02 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aSsAB-0007nf-PN for emacs-devel@gnu.org; Mon, 08 Feb 2016 15:12:01 -0500 Original-Received: from dancol.org ([2600:3c01::f03c:91ff:fedf:adf3]:36018) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSsAB-0007gb-EV for emacs-devel@gnu.org; Mon, 08 Feb 2016 15:11:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:To:Subject; bh=H2wOL1QfZOmFDdmZQKaFWGWS2xACCGRtrXWhmZk7Qog=; b=YHabYxu9DKJD+hLHpgBX4c0Twk7F7vueSlkhcfHeiRWsqBQ8CJzJwgazaxdBmgupmXqV2206J8LxZ71eQ3u6bfqhl7WpbQNcicGBESSYqAI1cRFWbcRp34bmxITh5fP9mmvg2VjamMJTWgHkpq67sWLnzNNO+Bs2zUwDw89rqhWorvgCBOsoEFAxzcZNIXJ4fMW7pIAqxT7XLBZGzZjVqQrBXU32quoXPHqUTqi0NriYLNZDA4Zx6vwu74/hL7t9yc9Z5QU3Z4zzuBwPrb2GSuCFkTP8hGMnPCCVJZC5eA51allruybRA5beVRJUzpWKEIucWGVT3U+28OfMApBgcg==; Original-Received: from [2620:10d:c090:200::9:5509] (helo=[IPv6:2620:10d:c083:10fb:2ab2:bdff:fe1c:db58]) by dancol.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84) (envelope-from ) id 1aSsA4-00066d-8Y; Mon, 08 Feb 2016 12:11:52 -0800 X-Enigmail-Draft-Status: N1110 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2600:3c01::f03c:91ff:fedf:adf3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:199552 Archived-At: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Kc6qxoHlsnx4gV134tQLXiwq0puWTG6pA Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 02/08/2016 11:55 AM, Stefan Monnier wrote: >>>>>> "Daniel" =3D=3D Daniel Colascione write= s: Huh. Where is that old email address coming from? >> Teach vc-hg how to read some Mercurial internal data structures, >> allowing us to avoid the need to run hg status -A, which is very s= low >> for large repositories. Fall back to running hg if anything looks= >> funny. vc-hg now puts the _working directory_ revision in the >> modeline instead of the file revision, which greatly improves >> performance and which allows us to again skip running hg in the ca= se >> that we have an active bookmark. >=20 > Thanks Daniel. Having written the same kind of thing for Bzr (tho it > was much simpler in that case), and taking a step back, I think this > reflects a mistake in VC: we probably just shouldn't provide such > detailed info in the modeline, or at least not until the user makes > explicit use of VC. >=20 > Having to go through the trouble of re-implementing part of the VCS to > parse the internal data to figure out the working revision, even though= > we have no idea if the user will ever care, is deeply unsatisfactory. I find the information useful, and we can now get it cheaply. Users can easily remove vc-hg from vc-handled-backends if they don't want the functionality. What might be worthwhile is making it easier to use vc for a file if that file's correct vc backend isn't vc-handled-backends --- that is, in that mode, we'd initialize the vc goo only when the user asks for it. I don't think that mode should be the default though. --Kc6qxoHlsnx4gV134tQLXiwq0puWTG6pA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCAAGBQJWuPaCAAoJEN4WImmbpWBlgNIQAKXqfQXD/PmtEDqC98CY8dvX z2KiH8JX0rNKVY9xKMyLhjnMRXSnccZslVLjfl0F4fs9zSfKVGuIKA8BCNG8lTPf IHrrxUOm3mMp4Pl5E4bZVGZrxS3goJU4QpFi0j+HBYODvHEskkP6PN3lAldSn4Ob S108FHtkUtk/TksYoceL3H9B8Ll+sRlXGCMfS4ANO/b88cJko9RxgqEJ1nF3JGNv 5sxxP2qtMzj6z6bkTWSguhB1zQWqEVZMyBPqFmVYlDwQjlU+VJM6WSx7t0eXo1yQ Wp9GDK1LN+1lKKIHM0SBqApm+pIEowUuWyc9JegJ83StMjYDUOpkar3/z9KxKNXM cuBlQ8yPxhogvSb19Qkc6LFUV8BeXn3e2SDGaEaR/+0liAHm4oT0icgqxD+Gep6B y2KhxNx/LHRdSE31Ay6o9Dfvkapop3Qp1JFLeq52rzDktX1wMK86Zd17lcQ9icz7 Gq1jY8NbPsaF7+gPi3fnnaWf3AZGsfYiuFvEKMk6NZyJYBxlZTsoFnM7b5HV9Lih ASvcvwbp+NJW4sOdCpnb1Fv44YSYFD7hgnP7xv1pv9SFp+s8NlPn6C9eKNgUSfbC B+HfyMhsKwqBBlnFtc/NSL7LxMsvA3gGJaGLmho6KPp78bQxs8PtKzx+ocQ1qCE8 p+k35qYF6oD2jeeZne88 =LbMP -----END PGP SIGNATURE----- --Kc6qxoHlsnx4gV134tQLXiwq0puWTG6pA--