From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: emacs-25 307e76c 4/6: Add dynamic module module support Date: Sun, 7 Feb 2016 07:49:23 -0800 Organization: UCLA Computer Science Department Message-ID: <56B76783.80906@cs.ucla.edu> References: <20151118192512.20738.15828@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------020707040303060301050007" X-Trace: ger.gmane.org 1454860199 25139 80.91.229.3 (7 Feb 2016 15:49:59 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 7 Feb 2016 15:49:59 +0000 (UTC) Cc: =?UTF-8?Q?Aur=c3=a9lien_Aptel?= To: Andreas Schwab , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Feb 07 16:49:49 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aSRat-00021Y-1U for ged-emacs-devel@m.gmane.org; Sun, 07 Feb 2016 16:49:47 +0100 Original-Received: from localhost ([::1]:35763 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSRas-0003vN-4c for ged-emacs-devel@m.gmane.org; Sun, 07 Feb 2016 10:49:46 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44486) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSRac-0003uN-Ao for emacs-devel@gnu.org; Sun, 07 Feb 2016 10:49:31 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aSRaZ-0007UI-3E for emacs-devel@gnu.org; Sun, 07 Feb 2016 10:49:30 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:45983) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aSRaY-0007Sk-TJ for emacs-devel@gnu.org; Sun, 07 Feb 2016 10:49:27 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 8ABC9160E48; Sun, 7 Feb 2016 07:49:25 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 6yNrwYAJGbw2; Sun, 7 Feb 2016 07:49:23 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id B84AD160F5C; Sun, 7 Feb 2016 07:49:23 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Eqxfk3rrkkOr; Sun, 7 Feb 2016 07:49:23 -0800 (PST) Original-Received: from [192.168.1.9] (pool-100-32-155-148.lsanca.fios.verizon.net [100.32.155.148]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 962B9160E48; Sun, 7 Feb 2016 07:49:23 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:199443 Archived-At: This is a multi-part message in MIME format. --------------020707040303060301050007 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Andreas Schwab wrote: > dladdr requires -ldl, but this check doesn't use LIBMODULES, which means > dladdr is never found here. Thanks for catching that. Fixed with the attached. --------------020707040303060301050007 Content-Type: text/x-diff; name="0001-Fix-test-for-dladdr.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-Fix-test-for-dladdr.patch" >From 6ca920f6718135a321ccc86dcbe3cf37efd7eb4e Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Sun, 7 Feb 2016 07:46:59 -0800 Subject: [PATCH] Fix test for dladdr Problem reported by Andreas Schwab in: http://lists.gnu.org/archive/html/emacs-devel/2016-02/msg00327.html * configure.ac (dladdr): Link with LIBMODULES when checking for this function. --- configure.ac | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 57bde94..1ff9c49 100644 --- a/configure.ac +++ b/configure.ac @@ -3360,7 +3360,7 @@ if test "${with_modules}" != "no"; then else SAVE_LIBS=$LIBS LIBS="$LIBS $LIBMODULES" - AC_CHECK_FUNCS([dlfunc]) + AC_CHECK_FUNCS([dladdr dlfunc]) LIBS=$SAVE_LIBS fi fi @@ -3373,7 +3373,6 @@ if test "${HAVE_MODULES}" = yes; then fi AC_SUBST(MODULES_OBJ) AC_SUBST(LIBMODULES) -AC_CHECK_FUNCS(dladdr) ### Use -lpng if available, unless '--with-png=no'. HAVE_PNG=no -- 2.5.0 --------------020707040303060301050007--