From: Paul Eggert <eggert@cs.ucla.edu>
To: Andreas Schwab <schwab@linux-m68k.org>, emacs-devel@gnu.org
Cc: "Aurélien Aptel" <aurelien.aptel@gmail.com>
Subject: Re: emacs-25 307e76c 4/6: Add dynamic module module support
Date: Sun, 7 Feb 2016 07:49:23 -0800 [thread overview]
Message-ID: <56B76783.80906@cs.ucla.edu> (raw)
In-Reply-To: <m2egco9795.fsf@linux-m68k.org>
[-- Attachment #1: Type: text/plain, Size: 179 bytes --]
Andreas Schwab wrote:
> dladdr requires -ldl, but this check doesn't use LIBMODULES, which means
> dladdr is never found here.
Thanks for catching that. Fixed with the attached.
[-- Attachment #2: 0001-Fix-test-for-dladdr.patch --]
[-- Type: text/x-diff, Size: 986 bytes --]
From 6ca920f6718135a321ccc86dcbe3cf37efd7eb4e Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Sun, 7 Feb 2016 07:46:59 -0800
Subject: [PATCH] Fix test for dladdr
Problem reported by Andreas Schwab in:
http://lists.gnu.org/archive/html/emacs-devel/2016-02/msg00327.html
* configure.ac (dladdr): Link with LIBMODULES when checking for
this function.
---
configure.ac | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/configure.ac b/configure.ac
index 57bde94..1ff9c49 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3360,7 +3360,7 @@ if test "${with_modules}" != "no"; then
else
SAVE_LIBS=$LIBS
LIBS="$LIBS $LIBMODULES"
- AC_CHECK_FUNCS([dlfunc])
+ AC_CHECK_FUNCS([dladdr dlfunc])
LIBS=$SAVE_LIBS
fi
fi
@@ -3373,7 +3373,6 @@ if test "${HAVE_MODULES}" = yes; then
fi
AC_SUBST(MODULES_OBJ)
AC_SUBST(LIBMODULES)
-AC_CHECK_FUNCS(dladdr)
### Use -lpng if available, unless '--with-png=no'.
HAVE_PNG=no
--
2.5.0
prev parent reply other threads:[~2016-02-07 15:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20151118192512.20738.15828@vcs.savannah.gnu.org>
[not found] ` <E1Zz8M2-0005RN-CB@vcs.savannah.gnu.org>
2016-02-07 9:53 ` emacs-25 307e76c 4/6: Add dynamic module module support Andreas Schwab
2016-02-07 15:49 ` Paul Eggert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B76783.80906@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=aurelien.aptel@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).