* Re: [Emacs-diffs] emacs-25 44c7b49: In xref-collect-references, force backends to respect the 'dir' arg [not found] ` <E1aMWdO-0002de-LR@vcs.savannah.gnu.org> @ 2016-01-28 1:17 ` Dmitry Gutov 2016-01-28 10:15 ` Stephen Leake 0 siblings, 1 reply; 5+ messages in thread From: Dmitry Gutov @ 2016-01-28 1:17 UTC (permalink / raw) To: emacs-devel, Stephen Leake On 01/22/2016 10:59 AM, Stephen Leake wrote: > branch: emacs-25 > commit 44c7b49d9a8188e8befc85f7e95d074ad4605c6a > Author: Stephen Leake <stephen_leake@stephe-leake.org> > Commit: Stephen Leake <stephen_leake@stephe-leake.org> > > In xref-collect-references, force backends to respect the 'dir' arg > > * lisp/progmodes/xref.el (xref-collect-references): Force symref backends > to use `default-directory'. Does this change work fine for you? The byte compiler complains that ede-minor-mode is an "unused lexical variable", so I expect there may be a problem with byte-compiled code. It there _is_ a problem, (defvar ede-minor-mode) should help. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Emacs-diffs] emacs-25 44c7b49: In xref-collect-references, force backends to respect the 'dir' arg 2016-01-28 1:17 ` [Emacs-diffs] emacs-25 44c7b49: In xref-collect-references, force backends to respect the 'dir' arg Dmitry Gutov @ 2016-01-28 10:15 ` Stephen Leake 2016-01-28 10:25 ` Dmitry Gutov 0 siblings, 1 reply; 5+ messages in thread From: Stephen Leake @ 2016-01-28 10:15 UTC (permalink / raw) To: Dmitry Gutov; +Cc: emacs-devel Dmitry Gutov <dgutov@yandex.ru> writes: > On 01/22/2016 10:59 AM, Stephen Leake wrote: >> branch: emacs-25 >> commit 44c7b49d9a8188e8befc85f7e95d074ad4605c6a >> Author: Stephen Leake <stephen_leake@stephe-leake.org> >> Commit: Stephen Leake <stephen_leake@stephe-leake.org> >> >> In xref-collect-references, force backends to respect the 'dir' arg >> >> * lisp/progmodes/xref.el (xref-collect-references): Force symref backends >> to use `default-directory'. > > Does this change work fine for you? Yes. > The byte compiler complains that ede-minor-mode is an "unused lexical > variable", so I expect there may be a problem with byte-compiled code. The `let' either binds the existing global variable, or creates a new local one; no problems. > It there _is_ a problem, (defvar ede-minor-mode) should help. I left that out by mistake. -- -- Stephe ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Emacs-diffs] emacs-25 44c7b49: In xref-collect-references, force backends to respect the 'dir' arg 2016-01-28 10:15 ` Stephen Leake @ 2016-01-28 10:25 ` Dmitry Gutov 2016-01-28 20:38 ` Stephen Leake 0 siblings, 1 reply; 5+ messages in thread From: Dmitry Gutov @ 2016-01-28 10:25 UTC (permalink / raw) To: Stephen Leake; +Cc: emacs-devel On 01/28/2016 01:15 PM, Stephen Leake wrote: >> The byte compiler complains that ede-minor-mode is an "unused lexical >> variable", so I expect there may be a problem with byte-compiled code. > > The `let' either binds the existing global variable, or creates a new > local one; no problems. IIUC, whether the variable is global or local, is being decided when a file is loaded, not at runtime. Thus, if ede.el is loaded after xref.el, ede-minor-mode binding there will be a local (lexical) one, and won't affect the global variable. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Emacs-diffs] emacs-25 44c7b49: In xref-collect-references, force backends to respect the 'dir' arg 2016-01-28 10:25 ` Dmitry Gutov @ 2016-01-28 20:38 ` Stephen Leake 2016-01-28 21:06 ` Dmitry Gutov 0 siblings, 1 reply; 5+ messages in thread From: Stephen Leake @ 2016-01-28 20:38 UTC (permalink / raw) To: Dmitry Gutov; +Cc: emacs-devel Dmitry Gutov <dgutov@yandex.ru> writes: > On 01/28/2016 01:15 PM, Stephen Leake wrote: > >>> The byte compiler complains that ede-minor-mode is an "unused lexical >>> variable", so I expect there may be a problem with byte-compiled code. >> >> The `let' either binds the existing global variable, or creates a new >> local one; no problems. > > IIUC, whether the variable is global or local, is being decided when a > file is loaded, or byte-compiled >not at runtime. Thus, if ede.el is loaded after > xref.el, ede-minor-mode binding there will be a local (lexical) one, > and won't affect the global variable. Yes, you are correct. I have only used it with ede loaded. -- -- Stephe ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Emacs-diffs] emacs-25 44c7b49: In xref-collect-references, force backends to respect the 'dir' arg 2016-01-28 20:38 ` Stephen Leake @ 2016-01-28 21:06 ` Dmitry Gutov 0 siblings, 0 replies; 5+ messages in thread From: Dmitry Gutov @ 2016-01-28 21:06 UTC (permalink / raw) To: Stephen Leake; +Cc: emacs-devel On 01/28/2016 11:38 PM, Stephen Leake wrote: > or byte-compiled > > Yes, you are correct. I have only used it with ede loaded. Right. Except I don't understand how your usage of ede could influence byte-compilation of xref.el. Did you byte-compile it from a running Emacs session, using M-x byte-compile, as opposed to doing that via 'make'? ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-01-28 21:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20160122075954.10103.93473@vcs.savannah.gnu.org>
[not found] ` <E1aMWdO-0002de-LR@vcs.savannah.gnu.org>
2016-01-28 1:17 ` [Emacs-diffs] emacs-25 44c7b49: In xref-collect-references, force backends to respect the 'dir' arg Dmitry Gutov
2016-01-28 10:15 ` Stephen Leake
2016-01-28 10:25 ` Dmitry Gutov
2016-01-28 20:38 ` Stephen Leake
2016-01-28 21:06 ` Dmitry Gutov
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).