From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 f8208b6: Document the user-level features of the Xref package Date: Fri, 22 Jan 2016 13:07:24 +0300 Message-ID: <56A1FF5C.1000406@yandex.ru> References: <20160109191428.26341.44105@vcs.savannah.gnu.org> <5691C9D2.7080905@yandex.ru> <83egdpmo1j.fsf@gnu.org> <56929D6F.2050508@yandex.ru> <834melmfa4.fsf@gnu.org> <5692B1E0.8010100@yandex.ru> <831t9pma4e.fsf@gnu.org> <5693FDFA.2070607@yandex.ru> <83ziwbkj5l.fsf@gnu.org> <5694055E.6050201@yandex.ru> <83si1udcaz.fsf@gnu.org> <569D64AC.1060606@yandex.ru> <83powxbh6c.fsf@gnu.org> <569EB04F.800@yandex.ru> <8337tsc133.fsf@gnu.org> <56A05073.5090100@yandex.ru> <83powu96yo.fsf@gnu.org> <86egda68q6.fsf@stephe-leake.org> <56A130FA.4040306@yandex.ru> <86bn8e3vvv.fsf@stephe-leake.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1453457263 30386 80.91.229.3 (22 Jan 2016 10:07:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 22 Jan 2016 10:07:43 +0000 (UTC) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Stephen Leake Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jan 22 11:07:42 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aMYd1-0007HT-VW for ged-emacs-devel@m.gmane.org; Fri, 22 Jan 2016 11:07:40 +0100 Original-Received: from localhost ([::1]:52258 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aMYd1-00050K-Bm for ged-emacs-devel@m.gmane.org; Fri, 22 Jan 2016 05:07:39 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52796) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aMYcu-0004zz-83 for emacs-devel@gnu.org; Fri, 22 Jan 2016 05:07:36 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aMYcp-0001UM-9G for emacs-devel@gnu.org; Fri, 22 Jan 2016 05:07:32 -0500 Original-Received: from mail-lf0-x234.google.com ([2a00:1450:4010:c07::234]:35922) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aMYco-0001TR-V2; Fri, 22 Jan 2016 05:07:27 -0500 Original-Received: by mail-lf0-x234.google.com with SMTP id h129so44230708lfh.3; Fri, 22 Jan 2016 02:07:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=a0/8hxvpcUTyTRrNb5zEKruSmHv9s8z0X3z6ZFPkrUQ=; b=GuznsmXOun6mHFuglB+XapvBFpDQhInFcXmQUNz1HYFAffUBYeMJv81Df4+V8miGPv 87hvFfznVBJT1RC53YW7veSB0CGZ78VgA+PgYS4yqliDT6r/S21k/t1zq4oq7qqmpScT nB1iaItEEsAoc5uzpY8KpgBmzyOJK6YrRLccX6KCmQydI5Z30hdNwKXmn8yA+hVYdsAy UD1TfjxAylAyabS684q4wOYuir/mDZlBMOS8LJa+Kl4OTsL94BeJtYAxHXRxoc7287jC uNzmxjIjNgsc0HKt79e1mFSpXr6G19OZzod7rgT+NOayPoznkBl4r6VQwlN7yEaSxbaD Mhcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=a0/8hxvpcUTyTRrNb5zEKruSmHv9s8z0X3z6ZFPkrUQ=; b=JYUDhvUjvb7nNwePdmKs5jsB+Ru/HmXSTOpKrLebJ9MZcyc+vBt+4ZzPGIih6avwEG twPiu0sYv5B4pB1dhMh+VxY3nuiZw6LO87lGmaHD3UE6q6FM2eQSioMRtAHXCb84B2cC Vbm8Pjy/USFCwWoCbfHHf9G9P9DGsCftBluCIfv7RRTuPGN8Q19JcuWtpR5dOrPTTaq1 Hsr97oM/qIMLpOkw0Rv9PxHj0CliMajOs2pj6Tt2MOajCPHEL19hFmaoskv9+huXceP1 l4IiPZmxP5lLxMagoKswxWl5kdc3heSq7Q5Q12oVuggRzGZ/hEEHul1PcNsoOH49zQQA b9Jw== X-Gm-Message-State: AG10YOTohLrPRR3JkchjDpDOkdh5FXJJcojZvrmluhsSN2OfqQPHrKdrFEOzFbONJnaEOQ== X-Received: by 10.25.149.21 with SMTP id x21mr902643lfd.124.1453457246002; Fri, 22 Jan 2016 02:07:26 -0800 (PST) Original-Received: from [192.168.1.190] ([178.252.127.222]) by smtp.googlemail.com with ESMTPSA id i192sm783373lfb.14.2016.01.22.02.07.24 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 22 Jan 2016 02:07:24 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:44.0) Gecko/20100101 Thunderbird/44.0 In-Reply-To: <86bn8e3vvv.fsf@stephe-leake.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c07::234 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:198569 Archived-At: On 01/22/2016 10:40 AM, Stephen Leake wrote: > The doc string says: > > Find all meaningful symbols that match PATTERN. > The argument has the same meaning as in ‘apropos’. > > I read that as "all occurances of the regexp"; I don't know what > "meaningful" is supposed to mean here. Symbol that are "meaningful" in the current runtime. Functions, variables, etc. > If it is supposed to find only definitions, the doc string should say > so: > > Find the definitions of all symbols that match PATTERN. > PATTERN has the same meaning as in `apropos'. Feel free to change the docstring to this. However, "find the symbols" semantics might be preferable, since we might want to show some additional info there, not just locations of their definitions. Just like M-x apropos does. > However, the etags implementation uses re-search-forward to find PATTERN > in the tags files; that won't handle word lists as `apropos' does. So > does that need to be fixed, or should we change the doc string further > to say: > > Find the definitions of all symbols that match PATTERN (a regexp). No. xref-find-apropos converts from PATTERN to a regexp itself. Just like `apropos'.