From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: [PATCH PING] Honor 'SOURCE_DATE_EPOCH' when generating autoloads. Date: Mon, 28 Dec 2015 10:00:22 -0800 Organization: UCLA Computer Science Department Message-ID: <568178B6.4000402@cs.ucla.edu> References: <87k2ph3mgx.fsf@gnu.org> <87io4lnkyz.fsf@gnu.org> <83mvtwoktg.fsf@gnu.org> <878u5gkakj.fsf@gnu.org> <83a8pwoesc.fsf@gnu.org> <87two3475d.fsf@gnu.org> <5665D6B9.4030309@cs.ucla.edu> <5665DAA1.2080208@cs.ucla.edu> <83k2o9t6t1.fsf@gnu.org> <56771D52.2070406@cs.ucla.edu> <83fuytp1au.fsf@gnu.org> <568073A4.3010604@cs.ucla.edu> <83ege6fsj1.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1451325657 29920 80.91.229.3 (28 Dec 2015 18:00:57 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 28 Dec 2015 18:00:57 +0000 (UTC) Cc: p.stephani2@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 28 19:00:48 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aDc6A-00039U-7L for ged-emacs-devel@m.gmane.org; Mon, 28 Dec 2015 19:00:46 +0100 Original-Received: from localhost ([::1]:45676 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDc69-0007hS-Pg for ged-emacs-devel@m.gmane.org; Mon, 28 Dec 2015 13:00:45 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49448) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDc5u-0007db-8h for emacs-devel@gnu.org; Mon, 28 Dec 2015 13:00:31 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aDc5t-0004ej-G7 for emacs-devel@gnu.org; Mon, 28 Dec 2015 13:00:30 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:42117) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDc5o-0004Yq-SN; Mon, 28 Dec 2015 13:00:25 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id BFF30160E6F; Mon, 28 Dec 2015 10:00:23 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id fF1Biz7Ss45f; Mon, 28 Dec 2015 10:00:22 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id C63C6160E74; Mon, 28 Dec 2015 10:00:22 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id kNxHrAABesYe; Mon, 28 Dec 2015 10:00:22 -0800 (PST) Original-Received: from [192.168.1.9] (pool-100-32-155-148.lsanca.fios.verizon.net [100.32.155.148]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id A4624160E6F; Mon, 28 Dec 2015 10:00:22 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 In-Reply-To: <83ege6fsj1.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:197023 Archived-At: Eli Zaretskii wrote: > Please let's nott remove this part, we are not removing the variable > (and won't be any time soon). Let's just document that the value can > be nil in a "deterministic build". OK, I will add the usual text saying that the variable can be nil if the information is not available. >> -;; I think this should be obsoleted/removed. It's just one more meaningless >> -;; difference between different builds. It's usually not even an fqdn. >> -(defconst emacs-build-system (system-name) >> - "Name of the system on which Emacs was built.") >> +(defconst emacs-build-system >> + (if (not deterministic-build) (system-name)) >> + "Name of the system on which Emacs was built, or nil if not available.") > > This causes an error in "M-x report-emacs-bug", so something should be > done here or there. What sort of error? It seems to work for me (not that I actually went all the way and sent the email). I had to back out the recent IDNA changes, as they broke report-emacs-bug -- perhaps that is what you noticed? > (I don't understand why you are so objected to > keeping this a string Consistency and simplicity. Consistency, because we should treat emacs-build-system consistently with other primitives like process-attributes and memory-info that return nil when the information is not available. Simplicity, because it's simpler for code to test for nil than for some reserved string like "unknown"; you can see examples of this in the most recent patch I proposed. Besides, we shouldn't prevent Emacs from working correctly on a machine whose host name really is "unknown".