From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 326ffcc: Allow line comments ending with escaped NL to be continued to the next line. Date: Mon, 28 Dec 2015 08:41:23 -0800 Organization: UCLA Computer Science Department Message-ID: <56816633.5050603@cs.ucla.edu> References: <20151228160034.7510.58055@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1451320909 15520 80.91.229.3 (28 Dec 2015 16:41:49 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 28 Dec 2015 16:41:49 +0000 (UTC) Cc: Alan Mackenzie To: Stefan Monnier , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 28 17:41:40 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aDarY-0007Nw-Id for ged-emacs-devel@m.gmane.org; Mon, 28 Dec 2015 17:41:36 +0100 Original-Received: from localhost ([::1]:45078 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDarY-0008Uj-5b for ged-emacs-devel@m.gmane.org; Mon, 28 Dec 2015 11:41:36 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56394) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDarU-0008UZ-VT for emacs-devel@gnu.org; Mon, 28 Dec 2015 11:41:33 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aDarR-0003CP-PM for emacs-devel@gnu.org; Mon, 28 Dec 2015 11:41:32 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:37712) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDarR-0003CJ-JA for emacs-devel@gnu.org; Mon, 28 Dec 2015 11:41:29 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id D89A5160095; Mon, 28 Dec 2015 08:41:27 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id ogMZ6H7xvOUx; Mon, 28 Dec 2015 08:41:27 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 37CA8160D3D; Mon, 28 Dec 2015 08:41:27 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id fGavwuon1O1Y; Mon, 28 Dec 2015 08:41:27 -0800 (PST) Original-Received: from [192.168.1.9] (pool-100-32-155-148.lsanca.fios.verizon.net [100.32.155.148]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 168D4160095; Mon, 28 Dec 2015 08:41:27 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:197014 Archived-At: Stefan Monnier wrote: > Hmm... the way I read this, it would mean that > > /*blabla\*/ > > will be treated as an unclosed comment. Is that the way C defines it as well? No, that's a closed comment. More interestingly, this: /\ \ *blabla*\ \ / printf ("\ \\ n\ "); is a closed comment followed by printf ("\n"), because backslash-newline removal is done before tokenization. So the "right" fix would be to ignore backslash-newline before identifying comments and other tokens. Backslash-backslash-newline can be tricky, as I recall from long ago when I was hacking on the GNU C preprocessor.