From: Dmitry Gutov <dgutov@yandex.ru>
To: Paul Eggert <eggert@cs.ucla.edu>, Eli Zaretskii <eliz@gnu.org>,
bruce.connor.am@gmail.com, dak@gnu.org, emacs-devel@gnu.org
Subject: Re: Should we have a commit size guideline?
Date: Wed, 16 Dec 2015 02:23:57 +0200 [thread overview]
Message-ID: <5670AF1D.1090803@yandex.ru> (raw)
In-Reply-To: <5670ACBC.8020203@cs.ucla.edu>
On 12/16/2015 02:13 AM, Paul Eggert wrote:
> That being said, it is annoying when part of a patch consists entirely
> of changing tabs to spaces or vice versa, as this one did,
Did it? Emacs doesn't change tabs to spaces if the indentation level of
the line hasn't changed.
And anyway, we've always considered tabs-to-spaces changes near some
actual changed code to be okay. If someone is having a problem reading
such diffs, Emacs has a wonderful diff-auto-refine-mode.
> This particular botch was undoubtedly caused by the line
> "(emacs-lisp-mode . ((indent-tabs-mode . nil)))" in .dir-locals.el,
> which was recently inserted in the (vain) attempt to get rid of all the
> tabs in .el source files, and we should probably remove that line as in
> practice it really causes more trouble than it's worth.
You're assuming that otherwise every committer would have
indent-tabs-mode set to nil, which undoubtedly isn't true.
Even if it were true, were this line to be removed, you'd still see the
same problem with people changing indentation from spaces to tabs in the
same fashion. There are a lot of lines indented with spaces already.
next prev parent reply other threads:[~2015-12-16 0:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-15 13:48 Should we have a commit size guideline? (was: builds are getting slower?) Artur Malabarba
2015-12-15 14:23 ` Should we have a commit size guideline? David Kastrup
2015-12-16 11:12 ` Artur Malabarba
2015-12-15 16:16 ` Should we have a commit size guideline? (was: builds are getting slower?) Eli Zaretskii
2015-12-15 17:56 ` Should we have a commit size guideline? John Wiegley
2015-12-16 0:13 ` Paul Eggert
2015-12-16 0:23 ` Dmitry Gutov [this message]
2015-12-16 1:00 ` Paul Eggert
2015-12-16 1:19 ` indent-tabs-mode setting in Emacs's dir-locals.el Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5670AF1D.1090803@yandex.ru \
--to=dgutov@yandex.ru \
--cc=bruce.connor.am@gmail.com \
--cc=dak@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).