From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: [PATCH PING] Honor 'SOURCE_DATE_EPOCH' when generating autoloads. Date: Sun, 29 Nov 2015 12:22:20 -0800 Organization: UCLA Computer Science Department Message-ID: <565B5E7C.1050601@cs.ucla.edu> References: <87k2ph3mgx.fsf@gnu.org> <87io4lnkyz.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1448828562 2155 80.91.229.3 (29 Nov 2015 20:22:42 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 29 Nov 2015 20:22:42 +0000 (UTC) To: =?UTF-8?Q?Ludovic_Court=c3=a8s?= , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 29 21:22:30 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a38UP-0006gA-Nf for ged-emacs-devel@m.gmane.org; Sun, 29 Nov 2015 21:22:30 +0100 Original-Received: from localhost ([::1]:37601 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a38UT-0000yT-KQ for ged-emacs-devel@m.gmane.org; Sun, 29 Nov 2015 15:22:33 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54742) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a38UP-0000yB-9w for emacs-devel@gnu.org; Sun, 29 Nov 2015 15:22:30 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a38UL-0007uQ-CR for emacs-devel@gnu.org; Sun, 29 Nov 2015 15:22:29 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:59505) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a38UL-0007uK-6z; Sun, 29 Nov 2015 15:22:25 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 509E9160779; Sun, 29 Nov 2015 12:22:24 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id E5hJiO081gWm; Sun, 29 Nov 2015 12:22:23 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 9DA7C160D95; Sun, 29 Nov 2015 12:22:23 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 9DTQd2WJRO9P; Sun, 29 Nov 2015 12:22:23 -0800 (PST) Original-Received: from [192.168.1.9] (pool-100-32-155-148.lsanca.fios.verizon.net [100.32.155.148]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 82CE9160779; Sun, 29 Nov 2015 12:22:23 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 In-Reply-To: <87io4lnkyz.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:195568 Archived-At: Ludovic Court=C3=A8s wrote: > * lisp/emacs-lisp/autoload.el (autoload-insert-section-header): Check > whether the 'SOURCE_DATE_EPOCH' environment variable is defined; use it > as the TIME part of the 'autoloads' sexp when it is. Thanks, but this patch is heading down the wrong direction. When we gene= rate an=20 autoloads list, we insert a checksum if we don't trust the date. We shou= ld do=20 that here, too. There should be no need for a SOURCE_DATE_EPOCH environm= ent=20 variable, for Emacs. Sorry if this process seems a bit unfriendly, by the way. Reviewing is o= ften a=20 pain.