From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 33ec2ff: Add one more mod-test test Date: Sun, 29 Nov 2015 10:21:39 -0500 Message-ID: <565B1803.5090805@cornell.edu> References: <20151124191433.3972.80810@vcs.savannah.gnu.org> <565A5EF3.1000900@cornell.edu> <83wpt1o4iw.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1448810515 28796 80.91.229.3 (29 Nov 2015 15:21:55 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 29 Nov 2015 15:21:55 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 29 16:21:41 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a33nI-00082X-8N for ged-emacs-devel@m.gmane.org; Sun, 29 Nov 2015 16:21:40 +0100 Original-Received: from localhost ([::1]:36635 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a33nM-0002WK-2b for ged-emacs-devel@m.gmane.org; Sun, 29 Nov 2015 10:21:44 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38521) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a33nI-0002WF-Uk for emacs-devel@gnu.org; Sun, 29 Nov 2015 10:21:41 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a33nF-0001d7-Qa for emacs-devel@gnu.org; Sun, 29 Nov 2015 10:21:40 -0500 Original-Received: from limerock03.mail.cornell.edu ([128.84.13.243]:49986) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a33nF-0001cv-MK; Sun, 29 Nov 2015 10:21:37 -0500 X-CornellRouted: This message has been Routed already. Original-Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock03.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id tATFLVQS007955; Sun, 29 Nov 2015 10:21:32 -0500 Original-Received: from [192.168.1.6] (cpe-67-249-176-138.twcny.res.rr.com [67.249.176.138]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id tATFLULA013535 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Sun, 29 Nov 2015 10:21:31 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 In-Reply-To: <83wpt1o4iw.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 128.84.13.243 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:195535 Archived-At: On 11/28/2015 10:42 PM, Eli Zaretskii wrote: >> From: Ken Brown >> Date: Sat, 28 Nov 2015 21:12:03 -0500 >> >> On 11/24/2015 2:14 PM, Eli Zaretskii wrote: >>> + (let ((descr (should-error (mod-test-sum 1 2 3)))) >>> + (should (eq (car descr) 'wrong-number-of-arguments)) >>> + (should (stringp (nth 1 descr))) >>> + (should (eq 0 >>> + (string-match >>> + (if (eq system-type 'windows-nt) >>> + "#" >>> + "#") >>> + (nth 1 descr)))) >> >> This fails on Cygwin because >> >> (should-error (mod-test-sum 1 2 3)) >> >> evaluates to >> >> (wrong-number-of-arguments "#" 3) >> >> This is like the expected value on MS-Windows, but without the "from". >> Does the missing "from" indicate a bug in the Cygwin build? > > It indicates that your dladdr implementation doesn't work (probably > returns zero). > > Please ask on the Cygwin list, and if dladdr is indeed missing, the > test should be updated to accommodate for this return value on Cygwin. Thanks. In fact, dladdr isn't implemented on Cygwin, so dynlib_addr always returns false. I'll update the test. Should the update be Cygwin-specific? According to http://linux.die.net/man/3/dladdr, dladdr is a glibc extension to POSIX, so there could conceivably be other systems with the same issue. Ken