From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Dynamic loading progress Date: Fri, 20 Nov 2015 12:39:01 -0800 Organization: UCLA Computer Science Department Message-ID: <564F84E5.2050801@cs.ucla.edu> References: <8737wgw7kf.fsf@lifelogs.com> <87io5bv1it.fsf@lifelogs.com> <87egfzuwca.fsf@lifelogs.com> <876118u6f2.fsf@lifelogs.com> <8737w3qero.fsf@lifelogs.com> <831tbn9g9j.fsf@gnu.org> <878u5upw7o.fsf@lifelogs.com> <83ziya8xph.fsf@gnu.org> <83y4du80xo.fsf@gnu.org> <837fld6lps.fsf@gnu.org> <83r3jk6fw6.fsf@gnu.org> <83k2pc6537.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1448051976 15564 80.91.229.3 (20 Nov 2015 20:39:36 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 20 Nov 2015 20:39:36 +0000 (UTC) Cc: aurelien.aptel+emacs@gmail.com, p.stephani2@gmail.com, tzz@lifelogs.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 20 21:39:26 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZzsSn-00018I-5A for ged-emacs-devel@m.gmane.org; Fri, 20 Nov 2015 21:39:21 +0100 Original-Received: from localhost ([::1]:49772 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzsSm-0006E0-Di for ged-emacs-devel@m.gmane.org; Fri, 20 Nov 2015 15:39:20 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37694) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzsSa-0006Dv-5F for emacs-devel@gnu.org; Fri, 20 Nov 2015 15:39:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZzsSZ-0000Jz-AL for emacs-devel@gnu.org; Fri, 20 Nov 2015 15:39:08 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:55668) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzsSV-0000Jd-E0; Fri, 20 Nov 2015 15:39:03 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id DB5D0160D74; Fri, 20 Nov 2015 12:39:02 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id XSfPkmFTkALu; Fri, 20 Nov 2015 12:39:02 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 34F12160DFD; Fri, 20 Nov 2015 12:39:02 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id U8eHg7Mc6t4x; Fri, 20 Nov 2015 12:39:02 -0800 (PST) Original-Received: from [192.168.1.9] (pool-100-32-155-148.lsanca.fios.verizon.net [100.32.155.148]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 0CC24160D74; Fri, 20 Nov 2015 12:39:02 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 In-Reply-To: <83k2pc6537.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:194894 Archived-At: Eli Zaretskii wrote: > I suspect the push_handlers changes in aa7dac8. No, it was the reindenting change! I got confused by the do-while indenting in a complicated macro. Fixed in commit 95f69f2c5999be4b9444861b6d4ae1bd3ab87f83. I also noticed some int/ptrdiff_t issues in mod-test.c, and fixed them in commit 39d13206f3b37261bf4a2ebadfc1103414f4fd3e. Plus, I assume emacs_module_init is part of the module API? If so, it should be declared in emacs-module.h, which I did in commit d0e07e0e2239771fd21b9525ea421cf7ba1cc97c. I didn't notice all these problems because I wasn't running that test. I was just doing 'make check'. Philipp, shouldn't mod-test.c part of 'make check', when Emacs is configured --with-modules? Also, shouldn't the mod-test.c Makefile use the same GCC warning flags etc. that everyone else does? That would help catch these bugs better.