From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Dynamic loading progress Date: Thu, 19 Nov 2015 15:51:29 -0800 Organization: UCLA Computer Science Department Message-ID: <564E6081.9010805@cs.ucla.edu> References: <877flswse5.fsf@lifelogs.com> <8737wgw7kf.fsf@lifelogs.com> <87io5bv1it.fsf@lifelogs.com> <87egfzuwca.fsf@lifelogs.com> <876118u6f2.fsf@lifelogs.com> <8737w3qero.fsf@lifelogs.com> <831tbn9g9j.fsf@gnu.org> <878u5upw7o.fsf@lifelogs.com> <83ziya8xph.fsf@gnu.org> <83y4du80xo.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1447977110 14811 80.91.229.3 (19 Nov 2015 23:51:50 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 19 Nov 2015 23:51:50 +0000 (UTC) Cc: emacs-devel@gnu.org To: Philipp Stephani , Eli Zaretskii , Ted Zlatanov , =?UTF-8?Q?Aur=c3=a9lien_Aptel?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 20 00:51:40 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZzYzL-0007jj-Bo for ged-emacs-devel@m.gmane.org; Fri, 20 Nov 2015 00:51:39 +0100 Original-Received: from localhost ([::1]:44565 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzYzK-0005zq-Q6 for ged-emacs-devel@m.gmane.org; Thu, 19 Nov 2015 18:51:38 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41401) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzYzH-0005zH-Oo for emacs-devel@gnu.org; Thu, 19 Nov 2015 18:51:36 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZzYzG-0003hl-PT for emacs-devel@gnu.org; Thu, 19 Nov 2015 18:51:35 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:41203) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzYzC-0003gO-OU; Thu, 19 Nov 2015 18:51:31 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 528B0160DFD; Thu, 19 Nov 2015 15:51:30 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id pJMhc3V4Y_0p; Thu, 19 Nov 2015 15:51:29 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 52DAF160DFE; Thu, 19 Nov 2015 15:51:29 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id BDgfnukpfqjM; Thu, 19 Nov 2015 15:51:29 -0800 (PST) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 3A084160DFD; Thu, 19 Nov 2015 15:51:29 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:194833 Archived-At: On 11/19/2015 02:41 PM, Philipp Stephani wrote: > > Yeah, that's a bug. I probably meant size to be declared as ptrdiff_t, > which is what ASIZE returns. I've fixed this by changing size_t to ptrdiff_t in the new code (or to int, if it's guaranteed to fit in INT_MAX). > According to > http://en.cppreference.com/w/c/language/struct_initialization and > https://gcc.gnu.org/onlinedocs/gcc/Designated-Inits.html designated > initializers are part of C99, which is required for building Emacs. I think designated initializers are pretty safe nowadays. (We don't assume all of C99 even now, by the way, just a reasonably portable subset; but this should be in the subset). That particular initializer is overkill, though. It's not obvious to the casual reader that it initializes the private members to zero, and I doubt whether any such initialization was intended. (This is one of the downsides of C99 initializers.) I simplified it. I have more work to do in this area and plan to follow up later.