From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Dynamic loading progress Date: Thu, 19 Nov 2015 07:55:34 -0800 Organization: UCLA Computer Science Department Message-ID: <564DF0F6.5060501@cs.ucla.edu> References: <877flswse5.fsf@lifelogs.com> <8737wgw7kf.fsf@lifelogs.com> <87io5bv1it.fsf@lifelogs.com> <87egfzuwca.fsf@lifelogs.com> <876118u6f2.fsf@lifelogs.com> <8737w3qero.fsf@lifelogs.com> <831tbn9g9j.fsf@gnu.org> <878u5upw7o.fsf@lifelogs.com> <83ziya8xph.fsf@gnu.org> <83y4du80xo.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1447948573 1545 80.91.229.3 (19 Nov 2015 15:56:13 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 19 Nov 2015 15:56:13 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii , Ted Zlatanov , =?UTF-8?Q?Aur=c3=a9lien_Aptel?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 19 16:56:04 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZzRZ5-0006e5-QD for ged-emacs-devel@m.gmane.org; Thu, 19 Nov 2015 16:56:04 +0100 Original-Received: from localhost ([::1]:42601 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzRZ5-0003CB-2i for ged-emacs-devel@m.gmane.org; Thu, 19 Nov 2015 10:56:03 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43015) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzRYs-0003C6-6C for emacs-devel@gnu.org; Thu, 19 Nov 2015 10:55:51 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZzRYr-0002Kq-57 for emacs-devel@gnu.org; Thu, 19 Nov 2015 10:55:50 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:41869) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzRYl-0002Gr-Ve; Thu, 19 Nov 2015 10:55:44 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id F1FDA160DFA; Thu, 19 Nov 2015 07:55:42 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id vAocAlYipLCz; Thu, 19 Nov 2015 07:55:37 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 6B2DD160E02; Thu, 19 Nov 2015 07:55:37 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id OTguL1I2-PWo; Thu, 19 Nov 2015 07:55:37 -0800 (PST) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 4D04A160DFA; Thu, 19 Nov 2015 07:55:37 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 In-Reply-To: <83y4du80xo.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:194793 Archived-At: Eli, thanks very much for doing that review. It's clear we have a lot of work to do in the new module code. I have also been reviewing it and have some changes sort-of-prepared, and I'll try to start folding them in soon. The main thing I noticed (that was not already in your list or in my upcoming changes) are some problems in memory allocation. The module code calls malloc directly, instead of xmalloc, for reasons I don't understand. This leads to problems, e.g., the memory is not properly accounted for by the memory profiler. Why can't the new module code invoke xmalloc? More generally, how should modules obtain memory in an Emacs-friendly way? Also, the file name "emacs_module.h" doesn't use the usual Emacs style rules; hyphen not underscore. But as you say, "module.h" would be better anyway. I'll change it to "module.h" for now; if there's some reason it needs an "emacs" prefix we can change it to "emacs-module.h" later. There are some other things I noticed which I'll try to summarize after fixing the stuff that's easy to fix (missing copyright notices, formatting, etc.).