From: martin rudalics <rudalics@gmx.at>
To: Joost Kremers <joostkremers@fastmail.fm>, Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Window splitting issues with margins
Date: Mon, 16 Nov 2015 19:56:45 +0100 [thread overview]
Message-ID: <564A26ED.6000208@gmx.at> (raw)
In-Reply-To: <87mvudlw6g.fsf@fastmail.fm>
> Columns
> that have such an associated SYM property are not considered reducible
> by `window-splittable-p'.
As I tried to explain before: ‘window-splittable-p’ is hardly the
function we care about here. We care about ‘split-window’ itself.
> It would still have to be possible for modes like writeroom-mode to set
> the margin to a specific width without setting a property, but those
> margins would be considered reducible by `window-splittable-p'.
> Furthermore, it shouldn't be possible to set a width that is smaller
> than what other modes have set. This could either be enforced by the API
> or writeroom-mode would have to ensure this itself.
There are two issues involved:
(1) ‘linum-mode’ sets the margin to some small, fixed value defeating
‘writeroom-mode’. I think this can be fixed by having ‘writeroom-mode’
set a ‘margins-min-width’ window parameter and have either
‘set_window_margins’ or modes like ‘linum-mode’ respect that value.
(2) When a window is split via ‘split-window-right’ or is shrunk
horizontally, ‘writeroom-mode’ probably should reset its margins (and
the window parameter) to some lower value. It should do that via
‘window-configuration-change-hook’ (when splitting) and
‘window-size-change-functions’ (when the window is resized). When the
splitting is undone or the window is sized back, ‘writeroom-mode’ will
probably want to enlarge the margins again.
martin
next prev parent reply other threads:[~2015-11-16 18:56 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 13:04 Window splitting issues with margins Joost Kremers
2015-11-12 14:31 ` martin rudalics
2015-11-12 16:28 ` Eli Zaretskii
2015-11-12 21:38 ` Joost Kremers
2015-11-13 8:04 ` martin rudalics
2015-11-13 8:40 ` Eli Zaretskii
2015-11-13 10:01 ` martin rudalics
2015-11-13 13:54 ` Eli Zaretskii
2015-11-13 14:53 ` martin rudalics
2015-11-13 18:34 ` Eli Zaretskii
2015-11-12 22:14 ` Joost Kremers
2015-11-13 8:04 ` martin rudalics
2015-11-13 8:43 ` Eli Zaretskii
2015-11-13 10:02 ` martin rudalics
2015-11-14 20:34 ` Joost Kremers
2015-11-16 15:53 ` Eli Zaretskii
2015-11-16 16:56 ` Joost Kremers
2015-11-16 18:56 ` martin rudalics [this message]
2015-11-16 20:11 ` Joost Kremers
2015-11-17 8:35 ` martin rudalics
2015-11-19 13:46 ` Joost Kremers
2015-11-20 8:21 ` martin rudalics
2015-11-25 13:10 ` Joost Kremers
2015-11-24 12:59 ` Joost Kremers
2015-11-24 19:26 ` martin rudalics
2015-11-25 19:53 ` Joost Kremers
2015-11-26 8:23 ` martin rudalics
2015-11-26 15:46 ` Eli Zaretskii
2015-11-26 16:58 ` martin rudalics
2015-11-26 17:13 ` Eli Zaretskii
2015-11-26 18:04 ` martin rudalics
2015-11-26 18:32 ` Eli Zaretskii
2015-11-27 8:26 ` martin rudalics
2015-11-27 9:00 ` Eli Zaretskii
2015-11-28 10:22 ` martin rudalics
2015-11-28 11:13 ` Eli Zaretskii
2015-11-14 20:47 ` Joost Kremers
2015-11-16 17:02 ` John Wiegley
2015-11-16 10:51 ` Yuri Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564A26ED.6000208@gmx.at \
--to=rudalics@gmx.at \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=joostkremers@fastmail.fm \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).