From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?UTF-8?Q?Przemys=c5=82aw_Wojnowski?= Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master a3b2101 1/2: New file with obarray functions. Date: Wed, 11 Nov 2015 22:22:02 +0100 Message-ID: <5643B17A.6010901@cumego.com> References: <20151111165602.28114.31123@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1447276959 4782 80.91.229.3 (11 Nov 2015 21:22:39 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 11 Nov 2015 21:22:39 +0000 (UTC) To: Stefan Monnier , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 11 22:22:16 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZwcqL-0006vW-Ao for ged-emacs-devel@m.gmane.org; Wed, 11 Nov 2015 22:22:13 +0100 Original-Received: from localhost ([::1]:43062 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwcqL-0004MV-I0 for ged-emacs-devel@m.gmane.org; Wed, 11 Nov 2015 16:22:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40796) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwcqH-0004Km-Dz for emacs-devel@gnu.org; Wed, 11 Nov 2015 16:22:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZwcqD-0006V0-GT for emacs-devel@gnu.org; Wed, 11 Nov 2015 16:22:09 -0500 Original-Received: from smtp23.iq.pl ([86.111.242.228]:59740) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwcqD-0006U8-6p for emacs-devel@gnu.org; Wed, 11 Nov 2015 16:22:05 -0500 Original-Received: (qmail 32717 invoked from network); 11 Nov 2015 21:22:03 -0000 Original-Received: from unknown (HELO [192.168.0.101]) (esperanto@cumego.com@[46.186.59.37]) (envelope-sender ) by smtp22.iq.pl with AES128-SHA encrypted SMTP for ; 11 Nov 2015 21:22:03 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 86.111.242.228 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:194148 Archived-At: W dniu 11.11.2015 o 21:26, Stefan Monnier pisze: >> New file with obarray functions. >> * lisp/obarray.el: basic obarray functions extracted from abbrev.el >> * test/automated/obarray-tests.el: new file > > Funnily enough, I think we should discourage the use of obarrays. > There are times/places where they are really indispensable (when we > really need to handle *symbols*), but in the majority of cases where > I could see this obarray.el being used, a hash-table would work better > (e.g. hash-table-p is more reliable, print+read actually works, access > is usually faster, ...). > > > Stefan Thanks for feedback. I just extracted obarray functionality from abbrev.el. This separates abbrev responsibility from underlying collection type to make both easier to test, understand and change if needed. Replace of implementation was not purpose of this commit.