From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: Font related crash? Date: Fri, 06 Nov 2015 12:26:11 +0100 Message-ID: <563C8E53.3040104@gmx.at> References: <837flxt8ue.fsf@gnu.org> <563B0B6A.9040207@gmx.at> <83y4ecs97w.fsf@gnu.org> <563B9D19.6000305@gmx.at> <83oaf8s2xv.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1446809199 21453 80.91.229.3 (6 Nov 2015 11:26:39 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 6 Nov 2015 11:26:39 +0000 (UTC) Cc: yuan.mei.list@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 06 12:26:32 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZufA8-0007WL-5p for ged-emacs-devel@m.gmane.org; Fri, 06 Nov 2015 12:26:32 +0100 Original-Received: from localhost ([::1]:38021 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZufA7-0004cW-Iw for ged-emacs-devel@m.gmane.org; Fri, 06 Nov 2015 06:26:31 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42941) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZufA3-0004aU-D8 for emacs-devel@gnu.org; Fri, 06 Nov 2015 06:26:28 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZufA0-00046g-1c for emacs-devel@gnu.org; Fri, 06 Nov 2015 06:26:27 -0500 Original-Received: from mout.gmx.net ([212.227.15.15]:63702) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zuf9u-00044g-4i; Fri, 06 Nov 2015 06:26:18 -0500 Original-Received: from [192.168.1.100] ([213.162.68.34]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0MTBLi-1a30c245MU-00S8BS; Fri, 06 Nov 2015 12:26:17 +0100 In-Reply-To: <83oaf8s2xv.fsf@gnu.org> X-Provags-ID: V03:K0:NLNk1YJXRt/fDHxzzWtAKdJMfcYz1Zvwd7fCfYj1vEcOsk19Hs3 3FjbIQfSxEsMbFNM8qb597h1Oatod7TQkBTpfRUahsRneL1ha/DzsM13aCzJBcxZSBMjLMv hutkXuyuYCuBMYavQTCCLzfWdbr+TJ3cmpvQBnMFJZ4VKJjvnJ3r017h1H36UOHeOHzvqEL cnWJAmSWFolV+aPACalPQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:OeaehP3kNJs=:JBiWs6NfegPBln7ftdMuTU q0hz9hJZnpk3DyRu2ckwj10dvt/nMGk52zEefJQxHBgA3//iRr1DqyaR6SdwgrOCWHIjzu7Q7 nMMQqNK84eIZIl61H+ZfQ+6UubuT+PtebY4P1i4Q6f/HEuW7bTPzCmLIG1/mj5y+rUBI2Vew3 re0ycO4QRelgGEeNb+XxPyiUUEXSH328ldB5u15jcMDElH5YjD/g60D6OOwmHJzOEaydaXH6z 2UBEmw0iT8XawKO+sLRi8j4r53op8Us4AqNMO2yWBcLSbyDygrT0gRS4aCSeYZhVSkL3HVKQg xr0hF567lphuHBFh+CDtbncWveViFmSYMtP6RUti5Bi6U2eyFrmGhbClRcvh80E3/2H15SQBc himBnG2kTNoEFr0fObfRGS4BPVKZ8znLr4tjlWQUXlRTIw/oeRScvSzP84pURfCbrMMZEOGau 6re8+lmBfpOJPuZCfnUjYv1O4NbH11XrIXoQ6QoVshCNfuAalxotroiDOsGegc4Z1UrBbDDZc sWMritsJzTMN38WgmhgiVaHFibkkoZPL0WWMS160CuukHnMijMX1FJ7Drc/EHPoUf0McO26aH zcZhKKpCWc+oKazlPYWiZUzFw0M5v4r1OKkD4Mua6tbaCk0XqZof+Po1ObCztUWf7IUKJgr3K Qeha2mgorc5/9ASLb8vHVO2qQW22uTdsB9220aZHb7iTf0Yw1qOu1x5XSP97JTCjDMjZwLW1i OKguNBTZ7G2t9EfREqjPTa1hZA0abYlaf8inXKBcBu9u1QGvB6MjOyVFuUHayxYEdRZ1c8vt X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.15.15 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:193404 Archived-At: > It can't, but later we have this: > > FRAME_DISPLAY_INFO (f)->n_fonts++; > if (FRAME_DISPLAY_INFO (f)->n_fonts == 1) > { > FRAME_SMALLEST_CHAR_WIDTH (f) = min_width; > FRAME_SMALLEST_FONT_HEIGHT (f) = height; > f->fonts_changed = 1; > } > else > { > if (FRAME_SMALLEST_CHAR_WIDTH (f) > min_width) > FRAME_SMALLEST_CHAR_WIDTH (f) = min_width, f->fonts_changed = 1; > if (FRAME_SMALLEST_FONT_HEIGHT (f) > height) > FRAME_SMALLEST_FONT_HEIGHT (f) = height, f->fonts_changed = 1; > } > > If, for some reason, n_fonts is not zero, Indeed. Though such behavior would be unforeseen and probably buggy too. > and > FRAME_SMALLEST_CHAR_WIDTH is zero, this will not do anything, and will > leave FRAME_SMALLEST_CHAR_WIDTH at zero. > [...] >> > Or maybe when we create a frame we should simply initialize >> > FRAME_SMALLEST_CHAR_WIDTH to 1 (and similarly with >> > FRAME_SMALLEST_FONT_HEIGHT). >> >> Or have these macros never provide zero. My only concern is that this >> might hide some underlying problem. > > Yes, but which one? Did you try reproducing this on X? I don't have these fontsets. martin