From: Bruno Haible <bruno@clisp.org>
To: Arthur Miller <arthur.miller@live.com>, Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Compiling in mingw-ucrt runtime
Date: Sun, 25 Feb 2024 15:11:22 +0100 [thread overview]
Message-ID: <5638518.yaVYbkx8dN@nimes> (raw)
In-Reply-To: <86zfvowxho.fsf@gnu.org>
Eli Zaretskii wrote:
> > > OK, but I asked also about the value of errno _after_ fclose is called
> > > and fails. It's important for understanding why it fails.
On native Windows, the value of errno, after fclose() fails, is undefined.
See here in the Gnulib documentation:
https://www.gnu.org/software/gnulib/manual/html_node/fclose.html
and here in the Microsoft documentation:
https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/fclose-fcloseall
(it sets errno only if the argument was a NULL pointer).
> > int
> > close_stream (FILE *stream)
> > {
> > ...
> > if (prev_fail || (fclose_fail && (some_pending || errno != EBADF)))
> > {
> > if (! fclose_fail)
> > errno = 0;
> > return EOF;
> > }
> >
> > return 0;
> > }
This code assumes that errno has a reasonable value after fclose() fails,
and is thus not portable to native Windows.
Let me see what I can do about it on the Gnulib side...
> Why does fclose fail, leaving errno at -1?
I cannot tell why fclose() failed in the first place.
Bruno
next prev parent reply other threads:[~2024-02-25 14:11 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 0:01 Compiling in mingw-ucrt runtime Arthur Miller
2024-02-22 6:24 ` Po Lu via Emacs development discussions.
2024-02-22 7:14 ` Eli Zaretskii
2024-02-23 7:58 ` Arthur Miller
2024-02-23 8:24 ` Eli Zaretskii
2024-02-23 11:32 ` Arthur Miller
2024-02-23 12:02 ` Eli Zaretskii
2024-02-24 9:13 ` Arthur Miller
2024-02-24 10:24 ` Eli Zaretskii
2024-02-24 23:11 ` Arthur Miller
2024-02-25 5:56 ` Po Lu
2024-02-25 6:33 ` Eli Zaretskii
2024-02-25 10:19 ` Arthur Miller
2024-02-25 10:48 ` Eli Zaretskii
2024-02-25 11:40 ` Arthur Miller
2024-02-25 12:15 ` Eli Zaretskii
2024-02-25 14:11 ` Bruno Haible [this message]
2024-02-25 14:29 ` Eli Zaretskii
2024-02-25 15:05 ` Bruno Haible
2024-02-25 15:14 ` Eli Zaretskii
2024-02-25 15:32 ` Bruno Haible
2024-02-25 16:02 ` Eli Zaretskii
2024-04-02 15:30 ` Arthur Miller
2024-04-02 16:28 ` Eli Zaretskii
2024-04-03 13:09 ` Arthur Miller
2024-02-23 14:47 ` Benjamin Riefenstahl
2024-02-23 15:03 ` Benjamin Riefenstahl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5638518.yaVYbkx8dN@nimes \
--to=bruno@clisp.org \
--cc=arthur.miller@live.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).