From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.devel Subject: Re: Bug#38708: eq vs eql in byte-compiled code Date: Tue, 31 Dec 2019 17:05:32 +0100 Message-ID: <5625EDCF-FC4B-4924-8574-E60DCAF830AF@acm.org> References: Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="49823"; mail-complaints-to="usenet@blaine.gmane.org" Cc: eliz@gnu.org, emacs-devel@gnu.org To: Pip Cet Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 31 17:41:35 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1imKaM-000CnB-M9 for ged-emacs-devel@m.gmane.org; Tue, 31 Dec 2019 17:41:35 +0100 Original-Received: from localhost ([::1]:44390 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1imKaL-0006Xs-0v for ged-emacs-devel@m.gmane.org; Tue, 31 Dec 2019 11:41:33 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42391) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1imKZo-00067m-Vd for emacs-devel@gnu.org; Tue, 31 Dec 2019 11:41:01 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1imKZo-0002I5-17 for emacs-devel@gnu.org; Tue, 31 Dec 2019 11:41:00 -0500 Original-Received: from mail1452c50.megamailservers.eu ([91.136.14.52]:39408 helo=mail266c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1imKZl-0001hn-S1; Tue, 31 Dec 2019 11:40:58 -0500 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1577808334; bh=yaWSnaJQ1FQphVxg0EubJ7QcsSunEJo7uqb09rm4Q68=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=seIBEfYcrN7neUf53Ba7nrecs2izFgeQrON4/u/bLBjbQGNuemqkSvPtMBkGXfIt0 oTSq+LfqvLai7G70rXdEGwcwm6XSLFrrgaqs7afRkc9OFHB+gFKtcdvjd1BnVvsvTL EdP0MGXYiNFMOyVq8M7jhfK2e9chd8yTrYBDtF9w= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.0.4] (c188-150-171-71.bredband.comhem.se [188.150.171.71]) (authenticated bits=0) by mail266c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id xBVG5X3r030626; Tue, 31 Dec 2019 16:05:34 +0000 In-Reply-To: X-Mailer: Apple Mail (2.3445.104.11) X-CTCH-RefID: str=0001.0A0B0205.5E0B71CE.0038, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=PNJxBsiC c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=pGLkceISAAAA:8 a=PVu0bGok5zzs6L_pITgA:9 a=CjuIK1q_8ugA:10 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] [fuzzy] X-Received-From: 91.136.14.52 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:243814 Archived-At: 31 dec. 2019 kl. 16.07 skrev Pip Cet : > For example, this code will produce t: >=20 > (defun my-eq (a b) (eq a b)) > (defun f () (xor (eq 1.0 1.0) (my-eq 1.0 1.0))) > (byte-compile 'f) > (f) The summary is correct (thank you). Let me just add that strings were = already deduplicated in the same way, so if 1.0 is replaced with "A" in = the code fragment above, the result is the same. And eq is no more = appropriate for flonums than for string literals.