unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: Wilson Snyder <wsnyder@wsnyder.org>
Cc: emacs-devel@gnu.org
Subject: Re: Backslash cleanup introduced bug [284c470e 9/17]
Date: Fri, 18 Sep 2015 09:41:23 -0700	[thread overview]
Message-ID: <55FC3EB3.3090908@cs.ucla.edu> (raw)
In-Reply-To: <7qsi6bc3du.fsf@emma.svaha.wsnyder.org>

On 09/18/2015 05:34 AM, Wilson Snyder wrote:
> One of your
> cleanups broke the verilog-mode.el package regressions.
>

Thanks for catching that.  I think you're referring to 753fbfbe, not to 
284c470e as the Subject: line says. 284c470e was intended to not change 
behavior. 753fbfbe was intended to fix behavior, but obviously I messed 
up in that instance (and thanks for fixing it). I now see that I also 
misclassified a few changes in 284c470e, as they actually did affect 
behavior (e.g., this change in verilog-mode.el:

-                (re-search-backward "/\*")
+                (re-search-backward "/\\*")

), but I think these misclassified changes all fixed bugs so it should 
be OK.

One other thing.  In 284c470e I tried to leave bugs alone when in 
doubt.  That is, although there are undoubtedly still some bugs related 
to backslashes, when in doubt I left behavior the same as it was 
before.  For example, lisp/net/tramp-adb.el has this:

(defcustom tramp-adb-prompt
"^\\(?:[[:digit:]]*|?\\)?\\(?:[[:alnum:]\e;[]*@[[:alnum:]]*[^#\\$]*\\)?[#\\$][[:space:]]"

and both instances of \\$ should probably be just $.  I wasn't sure, 
though, so I left them alone.



  reply	other threads:[~2015-09-18 16:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-18 12:34 Backslash cleanup introduced bug [284c470e 9/17] Wilson Snyder
2015-09-18 16:41 ` Paul Eggert [this message]
2015-09-18 16:45   ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55FC3EB3.3090908@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=emacs-devel@gnu.org \
    --cc=wsnyder@wsnyder.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).