From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: xref--read-identifier should call project-identifier-completion-table? Date: Mon, 3 Aug 2015 19:07:43 +0300 Message-ID: <55BF91CF.9080809@yandex.ru> References: <86k2tchfem.fsf@stephe-leake.org> <55BF3ABE.3020505@yandex.ru> <86zj28fl8u.fsf@stephe-leake.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1438618098 11683 80.91.229.3 (3 Aug 2015 16:08:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 3 Aug 2015 16:08:18 +0000 (UTC) To: Stephen Leake , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 03 18:08:13 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZMIHb-0007Xh-To for ged-emacs-devel@m.gmane.org; Mon, 03 Aug 2015 18:08:12 +0200 Original-Received: from localhost ([::1]:59794 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMIHb-0008Bd-3x for ged-emacs-devel@m.gmane.org; Mon, 03 Aug 2015 12:08:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59666) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMIHI-0007d2-El for emacs-devel@gnu.org; Mon, 03 Aug 2015 12:07:53 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZMIHE-0002ls-0t for emacs-devel@gnu.org; Mon, 03 Aug 2015 12:07:52 -0400 Original-Received: from mail-wi0-x22b.google.com ([2a00:1450:400c:c05::22b]:33259) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMIHD-0002lQ-NI for emacs-devel@gnu.org; Mon, 03 Aug 2015 12:07:47 -0400 Original-Received: by wicmv11 with SMTP id mv11so141836377wic.0 for ; Mon, 03 Aug 2015 09:07:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=5/lGe6Ib5v+SujX0PsqjPQPbqkZfarxJGjrEHiwMZqk=; b=oTWiYtSke2UuZopqA80OcRwKyV0aPDtXMf1AGuJOnjYlU0Dol2//0QiJZXv1EIdU9V Rhj9zye8YA0blJihz7QvZOrtIepNQFu2UfOEttV022p8zYYg2MdV2HpzDatSnXYTbJyy xk2cx7jvM4vIwXNaCzmcWdHG/vTIUalODcdcUJ95lYXsMZIAv+IrC6djT8uA40m5Tsjp rLU7UQFW5NcfugKyrEUe1Pc1/Rw9mujYXp07o2IVOm+UNAHZmAUgJE8UM2FT7z0F9Sf+ Gp41mA+wzW20TV4vmboRP8yMyEfCa4RINYS4ZxPDDRadpqY3/Q1XKcGBLSabaZlTav7F h/eA== X-Received: by 10.180.80.138 with SMTP id r10mr33270626wix.18.1438618067036; Mon, 03 Aug 2015 09:07:47 -0700 (PDT) Original-Received: from [10.9.0.103] (nat.webazilla.com. [78.140.128.228]) by smtp.googlemail.com with ESMTPSA id k12sm23621670wjw.4.2015.08.03.09.07.44 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Aug 2015 09:07:45 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:40.0) Gecko/20100101 Thunderbird/40.0 In-Reply-To: <86zj28fl8u.fsf@stephe-leake.org> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c05::22b X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:188352 Archived-At: On 08/03/2015 06:24 PM, Stephen Leake wrote: > I'm not clear if you are just talking about the rename here (that's what > you quoted), or the larger issue of having xref--read-identifier call > project-identifier-completion-table. A larger issue. The completion table just returns a list of strings. > I'll assume you are talking about the larger issue. > > Obviously I'll have to override functions that use xref-find-function > (and other similar function variables) as well, in my elisp project > backend. One step at a time ... Why override functions? Override the xref-find-function value instead. But anyway, these are scheduled to become generic functions, I just haven't gotten around to it yet. After "delayed buffers" (from a nearby thread). >> The natural extension of this approach would be to have a >> project-xref-backend accessor, but do we really need that? > > I don't know what that would be; can you give a more complete > description? You'll have to wait until then anyway, and maybe it'll become obvious. > The project backend should be fully determined by the result of > (project-current). It is only the presence of the function variables > used in non-dispatching functions that defeats that. I can't confidently answer this yet. > That's one approach. But I'd rather get rid of all of these function > variables in my backend; they just confuse things. I'd rather not add more methods than is strictly needed. > That's the point of my proposed change; to allow backends to eliminate > the use of the function variables. xref-find-function will become a generic function either way.