From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 7466a4d: Cygwin emacsclient handles w32 file names Date: Tue, 07 Jul 2015 10:36:53 -0400 Message-ID: <559BE405.9050209@cornell.edu> References: <5593F5BC.4030602@cornell.edu> <1279932406.858501.1435804110079.JavaMail.yahoo@mail.yahoo.com> <5595958F.1090400@cornell.edu> <5597F9BB.3000809@cornell.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1436279919 26078 80.91.229.3 (7 Jul 2015 14:38:39 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 7 Jul 2015 14:38:39 +0000 (UTC) Cc: "emacs-devel@gnu.org" To: Michael Mauger Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 07 16:38:31 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZCU0z-0005jF-SW for ged-emacs-devel@m.gmane.org; Tue, 07 Jul 2015 16:38:30 +0200 Original-Received: from localhost ([::1]:58619 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCU0z-0002yi-6k for ged-emacs-devel@m.gmane.org; Tue, 07 Jul 2015 10:38:29 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54637) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCTzW-0001jp-Fm for emacs-devel@gnu.org; Tue, 07 Jul 2015 10:37:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZCTzQ-0001k8-VB for emacs-devel@gnu.org; Tue, 07 Jul 2015 10:36:58 -0400 Original-Received: from limerock02.mail.cornell.edu ([128.84.13.242]:51823) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZCTzQ-0001jp-Oj for emacs-devel@gnu.org; Tue, 07 Jul 2015 10:36:52 -0400 X-CornellRouted: This message has been Routed already. Original-Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock02.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id t67EapVs031269; Tue, 7 Jul 2015 10:36:51 -0400 Original-Received: from [192.168.1.6] (cpe-67-249-176-138.twcny.res.rr.com [67.249.176.138]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id t67Eaoww001196 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Tue, 7 Jul 2015 10:36:51 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 In-Reply-To: <5597F9BB.3000809@cornell.edu> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 128.84.13.242 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:187765 Archived-At: On 7/4/2015 11:20 AM, Ken Brown wrote: > diff --git a/lisp/server.el b/lisp/server.el > index ce19b3c..46687a3 100644 > --- a/lisp/server.el > +++ b/lisp/server.el > @@ -1167,8 +1167,11 @@ The following commands are accepted by the client: > (let ((file (pop args-left))) > (if coding-system > (setq file (decode-coding-string file > coding-system))) > + ;; Allow Cygwin's emacsclient to be used as a file > + ;; handler on MS-Windows, in which case FILENAME > + ;; might start with a drive letter. > (when (and (eq system-type 'cygwin) > - (fboundp > 'cygwin-convert-file-name-from-windows)) > + (string-match "^[A-Za-z]:" file)) > (setq file (cygwin-convert-file-name-from-windows > file))) > (setq file (expand-file-name file dir)) > (push (cons file filepos) files) I've pushed this change (with Stefan's correction) as git commit b25770a. Ken