From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 7466a4d: Cygwin emacsclient handles w32 file names Date: Mon, 29 Jun 2015 22:40:13 -0400 Message-ID: <5592018D.7070303@cornell.edu> References: <20150630005924.5663.80677@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1435632046 12904 80.91.229.3 (30 Jun 2015 02:40:46 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 30 Jun 2015 02:40:46 +0000 (UTC) To: emacs-devel@gnu.org, "Michael R. Mauger" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jun 30 04:40:38 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Z9lTR-0005JJ-Je for ged-emacs-devel@m.gmane.org; Tue, 30 Jun 2015 04:40:37 +0200 Original-Received: from localhost ([::1]:44681 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9lTR-0005SY-1c for ged-emacs-devel@m.gmane.org; Mon, 29 Jun 2015 22:40:37 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35451) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9lTE-0005ST-Vp for emacs-devel@gnu.org; Mon, 29 Jun 2015 22:40:25 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z9lTB-0004aL-Cy for emacs-devel@gnu.org; Mon, 29 Jun 2015 22:40:24 -0400 Original-Received: from limerock02.mail.cornell.edu ([128.84.13.242]:52604) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9lTB-0004UI-8b for emacs-devel@gnu.org; Mon, 29 Jun 2015 22:40:21 -0400 X-CornellRouted: This message has been Routed already. Original-Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock02.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id t5U2eFrd003694; Mon, 29 Jun 2015 22:40:15 -0400 Original-Received: from [192.168.1.9] (cpe-67-249-176-138.twcny.res.rr.com [67.249.176.138]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id t5U2eDuY031127 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Mon, 29 Jun 2015 22:40:14 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 128.84.13.242 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:187659 Archived-At: On 6/29/2015 8:59 PM, Michael Mauger wrote: > branch: master > commit 7466a4ded6ded0bea50151395b7a0fccc5dfd167 > Author: Michael R. Mauger > Commit: Michael R. Mauger > > Cygwin emacsclient handles w32 file names > --- > lisp/server.el | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/lisp/server.el b/lisp/server.el > index 2007635..ce19b3c 100644 > --- a/lisp/server.el > +++ b/lisp/server.el > @@ -1167,6 +1167,9 @@ The following commands are accepted by the client: > (let ((file (pop args-left))) > (if coding-system > (setq file (decode-coding-string file coding-system))) > + (when (and (eq system-type 'cygwin) > + (fboundp 'cygwin-convert-file-name-from-windows)) There's no need for the 'fboundp ...' here; cygwin-convert-file-name-from-windows is defined in all Cygwin builds. > + (setq file (cygwin-convert-file-name-from-windows file))) > (setq file (expand-file-name file dir)) > (push (cons file filepos) files) > (server-log (format "New file: %s %s" Are you sure that emacsclient will still handle ordinary Cygwin file names properly after this change? I'm concerned about file names that contain characters from the (default) UTF-8 character set. I'm not very familiar with exactly how cygwin-convert-file-name-from-windows works, but its name suggests that it should be given a file name that's understood by Windows. Ken