From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix rendering issues on window managers without _NET_WM_STATE Date: Sun, 16 May 2021 10:30:29 +0200 Message-ID: <5591aa3f-1cec-36d6-cb07-201f1542a658@gmx.at> References: <015406d8-35d0-b76a-bee9-f2cc0c3d286c@gmx.at> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25785"; mail-complaints-to="usenet@ciao.gmane.io" Cc: =?UTF-8?Q?Adam_Sj=c3=b8gren?= , Emacs developers To: Tom Gillespie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun May 16 10:32:13 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1liCC4-0006d6-Gn for ged-emacs-devel@m.gmane-mx.org; Sun, 16 May 2021 10:32:12 +0200 Original-Received: from localhost ([::1]:43672 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1liCC3-0004hh-FM for ged-emacs-devel@m.gmane-mx.org; Sun, 16 May 2021 04:32:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58168) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liCAZ-0002b5-Q4 for emacs-devel@gnu.org; Sun, 16 May 2021 04:30:39 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:59867) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liCAW-0000EW-S2 for emacs-devel@gnu.org; Sun, 16 May 2021 04:30:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1621153830; bh=fnIIPq1d82TKsptr09S8d6rHZLEQFMKEfsumfnuXNVg=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=Q3cjLpCtODpGP3CSTeg5WEprJB9kbktxxz1wTmdWrxTyaxH2BR4IR9GHIf+FmL2pm TOMGgvt27StQG4vLWPaZ5jH3mIvofZK5eDbDfh6G6ZgP1Z4aFloYxFbcp/cI3wNcTA G8VcaVYDyffbSTB0J/v7MWmDpR3egRSiRz3nOFzU= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.100] ([212.95.5.102]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M4b1o-1ljqrI1bxm-001kMW; Sun, 16 May 2021 10:30:30 +0200 In-Reply-To: Content-Language: en-US X-Provags-ID: V03:K1:r0qwYHOUHbisPIbt6ZRusu7Y1haxNfvzABpvo3UQrLf8/4lYC8H V810nxQPIpgQeO328D9TNs0xap0amfHlhJZ2b1XJtB2K608dGEmj9Tp8/K35ibFC14gM9FA WyW2Vgu4SyXHx1Gwh9dw3tmrnDPxTVFFZW974jkQNtbynvCcSj+oeGFVpn/0bP7SOTgZro4 iWDu6u664N7EsrWm4rI5g== X-UI-Out-Filterresults: notjunk:1;V03:K0:GBl0YZnJWmk=:q1mrkr7Bs0ZJdOJ5KILb1W RcccI7Q4DyDb7IBZG1Rwd/BwlmFKSu1JpTLdfIO1oYxMyLlEslXpkkTK3IjNJpGmJdhJOd6Fz jAXDC0VEGANAWhix/PpBZq5sV1QP7G46XZzjRW2HctuQdz2vp5OewB5Vtn882FCtbadf+86Pt HOK6UEzxICBl+GEhiMQR95PEea04EOPwmkc211ORTmLlxxUlRI7Loqtzzz4dj6ucqMCRe3MCD tz5qiHccdgtb/jnkUp2X0zgqUutlkHHqmN80rRijsMrl/lgGYMlTxL88xzgBJLoK+rocNnEL4 KpH2a7kX6eiD9xvSRld7j3X9LMLzJwqU8n/jw3Gpc9DsRbDVyaecdHnEvyuAhLTymiHzbklhs iBhlNYKvxRf5fl9fEX6CeOrhz1uqpYGmUbE1CKwNJKoiBIcx6tNqCyUHt6Eo3qFQ7w3R/QzUm Igf+g33zWRXnDec4dPrMCh0KtHVJ2a4+zHT707i+4qiiIupWvWMBqZiAsRDyjxZYMA3ExvAeL 8TIMBgWSZpTvwuJOg+Gm12K3RtLRxteWSh/5lf6FU9x9IF5Ekf8wF1OkHAX7DKlUswbCLKDC3 4qq2pyW1FqweWFP2RV9ObYAtDJeh1iNL9L3sMYdzgT8o9nR1GEyD+se70+/y7Z9bRAfM39fyN zlKIPXKVqllgAXv6Ha+RzLInXU851eSmZGTFdwPylktaOVEyqJLF8DErALWPksrNtn525l2fZ wIDEDPBhUfWcc1Z9Tm8cBv6neQJ3UGhPKTW7xzHe0Bpf+cALIE11ywPg1IdViNwrqR1rv1hC Received-SPF: pass client-ip=212.227.15.18; envelope-from=rudalics@gmx.at; helo=mout.gmx.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269332 Archived-At: > Reporting that the solution based on VisibilityNotify resolves my > issue. Many thanks! And thanks for identifying the missing setting of _NET_WM_STATE as the culprit. IIUC this means that quite a number of WMs (fluxbox, Xmonad, Emacs' own EXWM, cwm) are not treated well by our calls of x_get_current_wm_state and x_handle_net_wm_state in handle_one_xevent and we probably should do away with that. Adam, given the above, can you think of fixing Bug#9893 in a way that is not based on _NET_WM_STATE? martin