unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [PATCH] lisp/net/newst-treeview.el: use :nt-feed instead of :tag
@ 2015-06-16 12:13 Cédric Chépied
  2015-06-16 17:57 ` Ulf Jasper
  0 siblings, 1 reply; 2+ messages in thread
From: Cédric Chépied @ 2015-06-16 12:13 UTC (permalink / raw)
  To: emacs-devel

Feeds in the newsticker treeview can sometimes have the same title (it occurs
with trac for example or when there is an error while retrieving the news). When
two feeds have the same title the commands newsticker-treeview-next-feed and
newsticker-treeview-prev-feed do not work because they are using the displayed
string to differentiate feeds.
This is a patch to use the :nt-feed property which is defined by the user.

---
 lisp/net/newst-treeview.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/net/newst-treeview.el b/lisp/net/newst-treeview.el
index a964750..df7628a 100644
--- a/lisp/net/newst-treeview.el
+++ b/lisp/net/newst-treeview.el
@@ -219,7 +219,7 @@ their id stays constant."
     ;;(message "%s/%s %s/%s" (widget-get node1 :tag) (widget-get node2 :tag)
     ;;       (or id1 -1) (or id2 -1))
     (or (newsticker--treeview-ids-eq id1 id2)
-        (string= (widget-get node1 :tag) (widget-get node2 :tag)))))
+        (string= (widget-get node1 :nt-feed) (widget-get node2 :nt-feed)))))
 
 (defun newsticker--treeview-do-get-node-of-feed (feed-name startnode)
    "Recursively search node for feed FEED-NAME starting from STARTNODE."
-- 
2.4.2



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] lisp/net/newst-treeview.el: use :nt-feed instead of :tag
  2015-06-16 12:13 [PATCH] lisp/net/newst-treeview.el: use :nt-feed instead of :tag Cédric Chépied
@ 2015-06-16 17:57 ` Ulf Jasper
  0 siblings, 0 replies; 2+ messages in thread
From: Ulf Jasper @ 2015-06-16 17:57 UTC (permalink / raw)
  To: Cédric Chépied; +Cc: emacs-devel

Applied.

Thanks!
Ulf



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-06-16 17:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-16 12:13 [PATCH] lisp/net/newst-treeview.el: use :nt-feed instead of :tag Cédric Chépied
2015-06-16 17:57 ` Ulf Jasper

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).