* Re: [elpa] master 54ced08 3/3: Merge remote-tracking branch 'ztree/master'
[not found] ` <E1Z3Tzw-00063x-5G@vcs.savannah.gnu.org>
@ 2015-06-13 14:23 ` Stefan Monnier
2015-06-13 20:55 ` Alexey Veretennikov
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2015-06-13 14:23 UTC (permalink / raw)
To: emacs-devel; +Cc: Alexey Veretennikov
> -;; Compatibility: GNU Emacs GNU Emacs 24.x
> +;; Compatibility: GNU Emacs 24.x
So is it OK if I change those files to use lexical-binding?
> (defun newline-and-begin ()
> "Move a point to the beginning of the next line."
> - (newline)
> + (insert "\n")
> (beginning-of-line))
The beginning-of-line can be removed as well (at which point you're
better off removing newline-and-begin altogether and simply replace every
call by (insert "\n")).
One more thing: I see that ztree-util.el defines several functions (such
as the one here) without a "ztree-" prefix. It would be good to fix this.
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [elpa] master 54ced08 3/3: Merge remote-tracking branch 'ztree/master'
2015-06-13 14:23 ` [elpa] master 54ced08 3/3: Merge remote-tracking branch 'ztree/master' Stefan Monnier
@ 2015-06-13 20:55 ` Alexey Veretennikov
2015-06-14 3:05 ` Stefan Monnier
0 siblings, 1 reply; 3+ messages in thread
From: Alexey Veretennikov @ 2015-06-13 20:55 UTC (permalink / raw)
To: Stefan Monnier, emacs-devel
Hi,
Thanks for comments, I've updated the code to use lexical-binding,
updated remaining function names and removed (redundant)
newline-and-begin, replacing it with (insert "\n").
Br,
/Alexey
On 13/06/15 16:23, Stefan Monnier wrote:
>> -;; Compatibility: GNU Emacs GNU Emacs 24.x
>> +;; Compatibility: GNU Emacs 24.x
> So is it OK if I change those files to use lexical-binding?
>
>> (defun newline-and-begin ()
>> "Move a point to the beginning of the next line."
>> - (newline)
>> + (insert "\n")
>> (beginning-of-line))
> The beginning-of-line can be removed as well (at which point you're
> better off removing newline-and-begin altogether and simply replace every
> call by (insert "\n")).
> One more thing: I see that ztree-util.el defines several functions (such
> as the one here) without a "ztree-" prefix. It would be good to fix this.
>
>
> Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [elpa] master 54ced08 3/3: Merge remote-tracking branch 'ztree/master'
2015-06-13 20:55 ` Alexey Veretennikov
@ 2015-06-14 3:05 ` Stefan Monnier
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Monnier @ 2015-06-14 3:05 UTC (permalink / raw)
To: Alexey Veretennikov; +Cc: emacs-devel
> Thanks for comments, I've updated the code to use lexical-binding, updated
> remaining function names and removed (redundant) newline-and-begin,
> replacing it with (insert "\n").
Thanks, looks good,
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-06-14 3:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20150612184810.23227.21127@vcs.savannah.gnu.org>
[not found] ` <E1Z3Tzw-00063x-5G@vcs.savannah.gnu.org>
2015-06-13 14:23 ` [elpa] master 54ced08 3/3: Merge remote-tracking branch 'ztree/master' Stefan Monnier
2015-06-13 20:55 ` Alexey Veretennikov
2015-06-14 3:05 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).