From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: "Eli Zaretskii" Newsgroups: gmane.emacs.devel Subject: Re: [jay_finger@hotmail.com: Two problems in Emacs-21.2.91 on Windows] Date: Wed, 23 Oct 2002 19:41:33 +0300 Sender: emacs-devel-admin@gnu.org Message-ID: <5567-Wed23Oct2002194131+0200-eliz@is.elta.co.il> References: <1990575.1035380255222.JavaMail.root@127.0.0.1> Reply-To: Eli Zaretskii NNTP-Posting-Host: main.gmane.org X-Trace: main.gmane.org 1035394950 24291 80.91.224.249 (23 Oct 2002 17:42:30 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Wed, 23 Oct 2002 17:42:30 +0000 (UTC) Cc: andrewi@gnu.org, akochoi@mac.com, jay_finger@hotmail.com, emacs-devel@gnu.org Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 184PWU-0006JS-00 for ; Wed, 23 Oct 2002 19:42:26 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 184PYH-0004gw-00 for ; Wed, 23 Oct 2002 19:44:17 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10) id 184PVS-0004rn-00; Wed, 23 Oct 2002 13:41:22 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10) id 184PUH-0004Qn-00 for emacs-devel@gnu.org; Wed, 23 Oct 2002 13:40:09 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10) id 184PUD-0004NU-00 for emacs-devel@gnu.org; Wed, 23 Oct 2002 13:40:08 -0400 Original-Received: from frigg.inter.net.il ([192.114.186.16]) by monty-python.gnu.org with esmtp (Exim 4.10) id 184PUC-0004LV-00; Wed, 23 Oct 2002 13:40:04 -0400 Original-Received: from zaretsky ([80.230.194.148]) by frigg.inter.net.il (Mirapoint Messaging Server MOS 3.2.1-GA) with ESMTP id BWG72134; Wed, 23 Oct 2002 19:39:51 +0200 (IST) Original-To: jasonr@btinternet.com X-Mailer: emacs 21.3.50 (via feedmail 8 I) and Blat ver 1.8.9 In-reply-to: <1990575.1035380255222.JavaMail.root@127.0.0.1> (jasonr@btinternet.com) Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.11 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.devel:8696 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:8696 > From: jasonr@btinternet.com > Date: Wed, 23 Oct 2002 14:37:35 +0100 (BST) > > I think the use of XColor in xfaces.c will affect > DOS as well. Yes. > I'm not sure if there is a convenient > header to put the definition in for the DOS build. msdos.h will do, I think (if it is #include'd by xfaces.c). But I don't really understand why should the definition in xfaces.c be removed. xfaces.c is mostly platform-independent, so it would make sense to actually leave that definition, perhaps with some more #ifdef's if Windows and Mac need that, and remoev the other bunch. Am I missing something?