From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: commit-msg hook Date: Tue, 14 Apr 2015 11:32:51 -0700 Organization: UCLA Computer Science Department Message-ID: <552D5D53.2020800@cs.ucla.edu> References: <83y4m0tgac.fsf@gnu.org> <55288A2D.5030809@cs.ucla.edu> <83d23bruui.fsf@gnu.org> <83a8yff0pl.fsf@gnu.org> <5529406D.4040304@cs.ucla.edu> <83sic6ehzc.fsf@gnu.org> <55297F68.4080103@cs.ucla.edu> <83lhhwc9lv.fsf@gnu.org> <552C0CEF.8070403@cs.ucla.edu> <83fv83dbo2.fsf@gnu.org> <552C32F7.5010206@cs.ucla.edu> <83pp76bvcv.fsf@gnu.org> <552D47D8.5020302@cs.ucla.edu> <838udubprd.fsf@gnu.org> <552D519D.1000907@cs.ucla.edu> <83618ybncm.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1429036397 32573 80.91.229.3 (14 Apr 2015 18:33:17 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 14 Apr 2015 18:33:17 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 14 20:33:08 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Yi5dx-0000xx-9n for ged-emacs-devel@m.gmane.org; Tue, 14 Apr 2015 20:33:05 +0200 Original-Received: from localhost ([::1]:57514 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yi5dv-0006vo-GC for ged-emacs-devel@m.gmane.org; Tue, 14 Apr 2015 14:33:03 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46481) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yi5dr-0006vT-BU for emacs-devel@gnu.org; Tue, 14 Apr 2015 14:33:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yi5dq-0003sa-Ej for emacs-devel@gnu.org; Tue, 14 Apr 2015 14:32:59 -0400 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:53404) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yi5dm-0003rm-Lq; Tue, 14 Apr 2015 14:32:54 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 2F0AAA6005C; Tue, 14 Apr 2015 11:32:52 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 97tTK1wpi5I1; Tue, 14 Apr 2015 11:32:51 -0700 (PDT) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 780BCA6002B; Tue, 14 Apr 2015 11:32:51 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 In-Reply-To: <83618ybncm.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:185424 Archived-At: On 04/14/2015 11:01 AM, Eli Zaretskii wrote: > You mean, like below? Looks good, yes. Some nits: > > --- ./.git/hooks/commit-msg.~5~ 2015-04-12 19:11:27.481125000 +0300 > +++ ./.git/hooks/commit-msg 2015-04-14 21:01:14.481125000 +0300 > @@ -37,6 +37,8 @@ > at_sign=`LC_ALL=en_US.UTF-8 $awk "$print_at_sign" /dev/null` > if test "$at_sign" = @; then > LC_ALL=en_US.UTF-8; export LC_ALL > + else > + LC_ALL=C; export LC_ALL > fi > fi > The duplicate 'export LC_ALL's can be hoisted out of the 'if'. > + non_print = "[\1-\37\177]|\302[\200-\237]|\355([\240-\257]|[\260-\277])[\200-\277]" > > "([\240-\257]|[\260-\277])" can be simplified to "[\240-\277]".