From: Paul Eggert <eggert@cs.ucla.edu>
To: Dhruva Krishnamurthy <dhruvakm@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Build segfaults when loading image.el
Date: Mon, 23 Dec 2019 18:51:28 -0800 [thread overview]
Message-ID: <550d1942-f29c-4801-356d-a8c4b3b77ea4@cs.ucla.edu> (raw)
In-Reply-To: <CAKOHPAn4GJCWzvkJPNM=UtfRwPK5AsrasQ7R6hW=ANm=OS-LAw@mail.gmail.com>
On 12/23/19 6:09 PM, Dhruva Krishnamurthy wrote:
> I still feel the original patch calling into IsMagickWandInstantiated() was
> more correct
Not sure I follow, but anyway any change along those lines would be more
experimental, whereas the emacs-27 branch is for bug-fixing and is maintained
more conservatively.
PS. I didn't notice the "!!IsMagickWandInstantiated();" part of your patch; if I
had, I would have omitted it from the emacs-27 branch and would have said why.
next prev parent reply other threads:[~2019-12-24 2:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-23 21:59 Build segfaults when loading image.el Dhruva Krishnamurthy
2019-12-23 22:43 ` Dhruva Krishnamurthy
2019-12-24 1:24 ` Paul Eggert
2019-12-24 2:09 ` Dhruva Krishnamurthy
2019-12-24 2:51 ` Paul Eggert [this message]
2019-12-24 15:38 ` Dhruva Krishnamurthy
2019-12-24 13:12 ` VanL
2019-12-24 13:22 ` Lars Ingebrigtsen
2019-12-25 2:03 ` VanL
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550d1942-f29c-4801-356d-a8c4b3b77ea4@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=dhruvakm@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).