From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.devel Subject: Re: Adding git-commit highlight mode? Date: Thu, 2 Jan 2025 21:26:44 -0800 Message-ID: <54c3a22c-b539-5e40-7f7a-82705366aadf@gmail.com> References: <37733be4476e1c2b6e873c967c79cb0035959a9e.camel@yandex.ru> <86wmfdhwg7.fsf@gnu.org> <0347118b217c57e4e62018547883fad5f1d1e63e.camel@yandex.ru> <86frm1hqv8.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24073"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Hi-Angel@yandex.ru, emacs-devel@gnu.org, jonas@bernoul.li To: Stefan Kangas , Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jan 03 06:27:50 2025 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tTaDu-0006AB-63 for ged-emacs-devel@m.gmane-mx.org; Fri, 03 Jan 2025 06:27:50 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tTaCw-0008To-FR; Fri, 03 Jan 2025 00:26:50 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tTaCu-0008TP-Lg for emacs-devel@gnu.org; Fri, 03 Jan 2025 00:26:48 -0500 Original-Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tTaCt-0000qN-9K; Fri, 03 Jan 2025 00:26:48 -0500 Original-Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-2162c0f6a39so172659895ad.0; Thu, 02 Jan 2025 21:26:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735882005; x=1736486805; darn=gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=2ynlGIk6zgXZ1W9CVfAoqnkmYG62aYZWfm0HZoITtmE=; b=WCbHZaBGxzppKfqmR7mj0LVErT1ZGTDcdR+HFOUJ/GKleZ9ON010faC2K5ExGelzU5 MECaA135LmxOZwKq6NG1AOrqpzwlu9R09WdPIMz9nmjwzu8Q0lK9XriHgRa1khvhoHsE O1I8NbNFiWSQUuo1YZJJEhEvu0BH9/GWSxfFqE5yIlPkKjx+zTgKUr5BCeBsaGQEFB9P DNnZzTEpUYxoyJRjkm/D8EXJdrdDJHYEElgxkP9yBowIHpBfG3Mff+nPnxVNc9L0kLo/ ZL2aNDYGx3goRTdtk+kn7S0ZVIBbrB1OhlZSnf579PJERDcHYz07Y8YQEDeK9n3pBEtB 5FLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735882005; x=1736486805; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2ynlGIk6zgXZ1W9CVfAoqnkmYG62aYZWfm0HZoITtmE=; b=j/teD7WtyeaAGjT8Bq/0CwX4A+SsyO48RTqJHBWfhHb68dJP9XY/3CJ5DvG/36HF5B ujc+EIkwEawc6+15Fbq/7bg6ozgMOkxxo2XyNcSVeg45QloiVCykxbZV7rWhfH0mMmKI +BDbPhrGf5WBjz4qZXezQxfzu4gRU7xMvCZuHYhGN3/zC69LFBqx5EwulEZuFyURF6wo BZzIfnurtYApSb4ST1qOoL1CanEWkjjUEapJf8OHcfu7aSwUdmNwccyXUJgV/tQor5wm PRHy7H1EYTMRA2jsY9uO/QQTNTqk7ZcW/uwFipcatjeylrSmIop+KDzQHeAKHxSEenPB 7nlg== X-Forwarded-Encrypted: i=1; AJvYcCXA1oysm5BW9vpcxqRb2oR+EMFoVhp4QpHEQh3PIojNo3TQOj/4RAL4ova1hxXn0IZP4mtZYIMhwBq7TGA=@gnu.org, AJvYcCXCXkU9HW/lpw2rwTVRq4uTkWY64vw7sf78XV+Q35tUDcGUwripwJGrx9OG6SNqvUT1NMB3@gnu.org X-Gm-Message-State: AOJu0Yxl+js+27hbqFRY/DKer9t8Hoo70Ith/bkdNMuSykAaHdEuOUdY lAGYS/KeY7cGHQgXgjNTLpd/qqudFNiVP9aUuMOYtCI7HzUAr7szqFBtuw== X-Gm-Gg: ASbGncu9cjtVbT9EaafBRYPgK9TlcikbcXp2TvfLXKcthMtOwZvq9Q9900H9IMt72Qx Hx1SouJzUVNqqpA3uP/85gOHd1DvBYwtXHeDNpgy0TtJWRPHyLVgazftJQDXw+WHWPUP8F3eIMi JSzf8qLFYDiuxyb5rowZKkglceUQvQ/G/Wueu3v/09Dm8upQ9xBJjLt/m4jAJg0C9Ubycy91MUn h2LkqIU/Goym9VEzUniCuqfYvp0sVWcs/Jf7c0G4AeW2g4Rl3pnlDhaLhMCH8c3tWQbDIMfD5IB WMioXhS3rUFh9prUSrkZd7OoQ6l339j9pA== X-Google-Smtp-Source: AGHT+IHf1/Etg3+G40m1jG9llFMp5DD5R/ySBN1ahUpzuYUQgpqB+wFkWjFB6SUVfpRkAlqF4nTU2Q== X-Received: by 2002:a05:6a21:6d96:b0:1d9:d5e:8297 with SMTP id adf61e73a8af0-1e5e1e269e1mr55846984637.6.1735882005156; Thu, 02 Jan 2025 21:26:45 -0800 (PST) Original-Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-72aad816413sm25272470b3a.38.2025.01.02.21.26.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jan 2025 21:26:44 -0800 (PST) Content-Language: en-US In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::62a; envelope-from=jporterbugs@gmail.com; helo=mail-pl1-x62a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:327606 Archived-At: On 1/2/2025 1:38 PM, Stefan Kangas wrote: > Instead of inheriting from it, I'd propose creating an optional minor > mode, that users can enabled when they need to, plus a globalized mode > for those that want it on always. That would also expand it to be > useful also with Magit's `git-commit-mode`, for example, which I'd > personally welcome. (FWIW, I happen to think that the paragraph filling > rules would be the most interesting feature in such a minor mode.) You took the words out of my mouth. :) I'm not sure about all the details here, but some way of "embedding" change-log-mode into other major modes would be really helpful. Maybe there are other ways to do this instead, like multi-major-mode support (e.g. in html-mode and the like), but I think it makes sense not to *require* change-log-mode if it could get in the way for users who don't write commits like that.