From: Paul Eggert <eggert@cs.ucla.edu>
To: Eli Zaretskii <eliz@gnu.org>, Juanma Barranquero <lekktu@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Docstring of make-symbolic-link
Date: Tue, 11 Jun 2019 08:50:21 -0700 [thread overview]
Message-ID: <54a3ebd9-c981-3dbe-476a-a60b64833547@cs.ucla.edu> (raw)
In-Reply-To: <83h88w9p6x.fsf@gnu.org>
On 6/11/19 7:22 AM, Eli Zaretskii wrote:
> This appears to be some kind of copy-pasta from add-name-to-file,
> which creates a hard link.
Yes, and that's a good thing because hard links and symbolic links are
similar here.
We should use "NEWNAME" here, not merely for consistency with
add-name-to-file, but also because using "NEWNAME" makes it clearer that
it's the thing being created instead of TARGET. It's all too easy to
misread "(make-symbolic-link TARGET LINKNAME)" as meaning that TARGET
gets created with the contents LINKNAME, which is the opposite of what
the function actually does.
next prev parent reply other threads:[~2019-06-11 15:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-10 19:44 Docstring of make-symbolic-link Juanma Barranquero
2019-06-11 14:22 ` Eli Zaretskii
2019-06-11 15:50 ` Paul Eggert [this message]
2019-06-12 22:31 ` Juanma Barranquero
2019-06-13 4:53 ` Eli Zaretskii
2019-06-13 7:41 ` Juanma Barranquero
2019-06-13 8:57 ` Eli Zaretskii
2019-06-19 21:33 ` Juanma Barranquero
2019-06-21 7:52 ` Eli Zaretskii
2019-06-21 7:57 ` Juanma Barranquero
2019-06-21 8:24 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54a3ebd9-c981-3dbe-476a-a60b64833547@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).