From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Requesting patch review Date: Tue, 10 Mar 2015 01:36:28 +0200 Message-ID: <54FE2E7C.2050905@yandex.ru> References: <54FC8D03.1060503@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1425944219 9472 80.91.229.3 (9 Mar 2015 23:36:59 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 9 Mar 2015 23:36:59 +0000 (UTC) Cc: emacs-devel To: Jackson Hamilton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 10 00:36:53 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YV7E9-0008KY-UG for ged-emacs-devel@m.gmane.org; Tue, 10 Mar 2015 00:36:50 +0100 Original-Received: from localhost ([::1]:45764 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YV7E8-00053W-RX for ged-emacs-devel@m.gmane.org; Mon, 09 Mar 2015 19:36:48 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47954) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YV7Dv-00053D-Ga for emacs-devel@gnu.org; Mon, 09 Mar 2015 19:36:36 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YV7Ds-0005ww-A6 for emacs-devel@gnu.org; Mon, 09 Mar 2015 19:36:35 -0400 Original-Received: from mail-wi0-x231.google.com ([2a00:1450:400c:c05::231]:38448) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YV7Ds-0005wA-3U for emacs-devel@gnu.org; Mon, 09 Mar 2015 19:36:32 -0400 Original-Received: by widex7 with SMTP id ex7so25023742wid.3 for ; Mon, 09 Mar 2015 16:36:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=mKm90O79n1jwOeHiT/DIOBHo/bLmRiHIDTL/tZO+sQA=; b=kIVXvoeiWjFK/zm2LtbEAREBd7ewLFumEW/eNYVlTOpBB8oFJGDQa8ArzN7mSOxcj7 kJCE8yIbldX/zF/WK0zsP2bpLMerELmgJ5iVddyreGgKTCyiszfJW74/R78usxN6yrT4 T6th3ichdOWjb83D6OMo5IDuM+wEoBavJs1EnaWoTxAAeIY/M5vcYsO3ZwaOpPHVqi9l kiZynwW8X5Bb4xqma78q14uzQYSpL9NSc747W9OwxCiQeQTQPggw5/28Eu5nDifzTvvA Cj89ATedZwZ8rCwf1iSBcMUKNETDDORONMNmh1UPkdlNVs7igpL+jpP6J+gz5pgNfHv0 wHag== X-Received: by 10.194.143.20 with SMTP id sa20mr9060559wjb.75.1425944190865; Mon, 09 Mar 2015 16:36:30 -0700 (PDT) Original-Received: from [192.168.1.3] ([82.102.93.54]) by mx.google.com with ESMTPSA id q10sm28805245wjr.41.2015.03.09.16.36.29 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Mar 2015 16:36:30 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:36.0) Gecko/20100101 Thunderbird/36.0 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c05::231 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:183748 Archived-At: On 03/09/2015 12:01 AM, Jackson Hamilton wrote: > For the sake of continuity I'll send my next patch through this email > thread, but in the future I will send them to the bug tracker. Exactly what I was thinking. > Refactored the code to be less tricky, added the additional level of > configuration and ported the tests. Thanks! That's a bit too many test examples for my taste (especially in js-indent-first-initialiser-t.js, since that piece of implementation is relatively trivial), but I guess that's still much better than no tests. Regarding the meat of the change, it should be "initializer" (Emacs prefers US spelling), and maybe we should also extract the added lines into a utility function, in order not to make `js--proper-indentation' even longer than it is now.