From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Requesting patch review Date: Sun, 08 Mar 2015 19:55:15 +0200 Message-ID: <54FC8D03.1060503@yandex.ru> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1425837368 4741 80.91.229.3 (8 Mar 2015 17:56:08 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 8 Mar 2015 17:56:08 +0000 (UTC) To: Jackson Hamilton , emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 08 18:55:52 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YUfQd-00025e-Mp for ged-emacs-devel@m.gmane.org; Sun, 08 Mar 2015 18:55:51 +0100 Original-Received: from localhost ([::1]:39886 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YUfQd-0005f1-Aj for ged-emacs-devel@m.gmane.org; Sun, 08 Mar 2015 13:55:51 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39791) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YUfQG-0005Vf-PD for emacs-devel@gnu.org; Sun, 08 Mar 2015 13:55:30 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YUfQB-0004QJ-HV for emacs-devel@gnu.org; Sun, 08 Mar 2015 13:55:28 -0400 Original-Received: from mail-we0-x22d.google.com ([2a00:1450:400c:c03::22d]:41847) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YUfQB-0004PR-A6 for emacs-devel@gnu.org; Sun, 08 Mar 2015 13:55:23 -0400 Original-Received: by wevm14 with SMTP id m14so69611386wev.8 for ; Sun, 08 Mar 2015 10:55:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=/GPoHwNZxhpNG9Yb0NoX+35hXXeDhYvspqvpTWJqzrA=; b=joRRINyUfyTTV8FFUhDqsZnlVJG92HPlb6g1/Ap0UBmElB9d+cb6weqamwNr89ZVZR +gZ6N4SeGjrEYhA6U983OgXqS8ydw+zvrKCLMa8Eiw04IGLfhPe6VoxouP/Rr79TpRLi AdfqAjJ18E2iTYJ+EN73mJpuVDJKeLMECWzflZyTLQRfyvcisMBjbE/FjYITxwGQGV73 QFL43U3ihVToMhVSgYKEhjwkrqFfhV9ylTQNA/JesDF/J+/emqbuAkaY5SHxygeTGCmt m4wM20598qNjzTkGi4nA1yfMLILngV3Av8i1MQBBYT9xdNoQi1n73CbNWc3eX9vFPYPN Rgwg== X-Received: by 10.194.187.236 with SMTP id fv12mr50734887wjc.131.1425837321897; Sun, 08 Mar 2015 10:55:21 -0700 (PDT) Original-Received: from [192.168.1.3] ([82.102.93.54]) by mx.google.com with ESMTPSA id v16sm11931952wib.5.2015.03.08.10.55.19 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 08 Mar 2015 10:55:19 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:36.0) Gecko/20100101 Thunderbird/36.0 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c03::22d X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:183732 Archived-At: On 03/08/2015 04:09 AM, Jackson Hamilton wrote: > New patch for js-mode. Adds a new indentation option. I would appreciate > review before merging. Thanks for the patch. I can see two directions for it to be improved: - Port the tests. I suppose test/indent/*.js would be a good place for the examples. You can create js-???.js, set the new option's, value using file local variables (in a comment, at the top or the bottom of the file), and then the right indentation would be tested automatically. Run a single file with 'make js.js.test'. - Add the option for the user to always have this indentation, no matter if there's a comma after the first item or not. js2-mode can do that (here's the original feature request: https://github.com/mooz/js2-mode/issues/3). I suppose it'd be best if the new variable had a different name and 3 possible values (nil - default, t - always, dynamic - check to see if there are several declarations). By the way, in general it's better to send patches to the bug tracker. They can get lost in emacs-devel if nobody pays attention right away.