From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daniel Colascione Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 9d8d065: Add support for finalizers Date: Tue, 03 Mar 2015 09:08:54 -0800 Message-ID: <54F5EAA6.8030403@dancol.org> References: <20150302233934.18904.59563@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GVvAxVC98GTGJkeRPBbOljieBT48vuH7a" X-Trace: ger.gmane.org 1425402567 19923 80.91.229.3 (3 Mar 2015 17:09:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 3 Mar 2015 17:09:27 +0000 (UTC) To: Stefan Monnier , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 03 18:09:21 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YSqJh-0007nh-7Z for ged-emacs-devel@m.gmane.org; Tue, 03 Mar 2015 18:09:09 +0100 Original-Received: from localhost ([::1]:39929 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSqJg-0004Dr-6E for ged-emacs-devel@m.gmane.org; Tue, 03 Mar 2015 12:09:08 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52923) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSqJc-0004B9-Ml for emacs-devel@gnu.org; Tue, 03 Mar 2015 12:09:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YSqJZ-0007SB-AZ for emacs-devel@gnu.org; Tue, 03 Mar 2015 12:09:04 -0500 Original-Received: from dancol.org ([2600:3c01::f03c:91ff:fedf:adf3]:60464) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YSqJZ-0007Rw-0d for emacs-devel@gnu.org; Tue, 03 Mar 2015 12:09:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Type:In-Reply-To:References:Subject:To:MIME-Version:From:Date:Message-ID; bh=cZRuGCwFqbyu58wppHcLnO9tEvTHSXrmjom1VvT8Lvo=; b=hSxksaRVwlLuKLa4J3UbuIo9b4xEQw6eMkOG2VEqpPrNV8beCbHwb3sjP4muLLaeBTgIbNJ8lv4t/hsgcdkKjhDSEa7uNfYrSu4mKSlkrhM1umY0bX0NcspwuuYrpIdrsTK5oP2b+cMg+mwWIxxijwXyQPbIszxk5ahEgQgsXlRsWsfk/05HX/CWs3fMy33olNGS8gJhcCOPoRaVh8uMUwAI4zyx6Fsv/uaT5NLsZvTdRRWzO6p24wimcwChlFCMhAhtczEDpMPFfOQgY9ANJv3ICNZT3X50ovhfkrJ8t0r37/mv56Eaha7gcj90xG11RVLroDQtCx+Dk0HZOreMCA==; Original-Received: from c-73-221-38-18.hsd1.wa.comcast.net ([73.221.38.18] helo=[192.168.1.210]) by dancol.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84) (envelope-from ) id 1YSqJX-0006tw-S6; Tue, 03 Mar 2015 09:08:59 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2600:3c01::f03c:91ff:fedf:adf3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:183603 Archived-At: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --GVvAxVC98GTGJkeRPBbOljieBT48vuH7a Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 03/03/2015 09:03 AM, Stefan Monnier wrote: > Was this discussed on emacs-devel and I missed it? No. > Question: why use a doubly-linked list, unlike pretty much everything > else in our code base? We remove finalizers from the middle of the list in unchain_finalizer. We could just rebuild the list as we scan it, but when we'd have to touch every node. Or we could maintain auxiliary state, but then in run_finalizers we'd have to scan the whole list instead of the part we're running. >> + DEFVAR_BOOL ("gc-precise-p", gc_precise_p, >=20 > This name is wrong. "-p" stands for "predicate" and a predicate is > a function that returns a boolean, whereas this is a variable/constant.= I've also seen it for boolean-valued variables. --GVvAxVC98GTGJkeRPBbOljieBT48vuH7a Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCAAGBQJU9eqmAAoJEN4WImmbpWBlbzsQAIcxNGyQl7A5kWBnPKDivQAN ndRd6+ySPanmm2feKc2v4knfFd6CQHTbZyAiUc2SY1jTGNj7VD9C5bN8/iPEwXt+ iuZQoRBVTVcouljH4pja874nxf7vLcVQsth8I/UQAhdxQbkQF7TR4f/Ijh4Ldbjo ZJ01BqRqLaZcx0EOhbgPSMWtLEvRgh4RsdJLLu2o27VpOdhpcO08onuaowqePRTu nN7OvfL6w9Rq8HQFxCDZbjDc0htcWAj6Ol5AG/oXlb/Jpf/hUjpnBaSGcNMzaTah ODsmsMm0J6REhQp/bgzCyn3y+HjNwmqfrGxl/QSOiHVjuvGzjrPSRoGVyeY5lpy/ 94Bf39mGOi2uLtCsUDArlh6YGWyc+Tforfk4ybkTwqsB3zdS0lyo9hUnQcQ6Ch7f qI8RFX0bMNMtqDa+nSibJJcDIXzpTlVF1bs85jKWXf2OD5gbEIHuwqD4DvBUfNfW dv8KIiwIXFRqVAlic4IgXHwXkNATB1CRfOjI60CH7dGe0CTUWzAZ2fujUTpWDzJR 4+1Wk2eHNZHNxh01i1TDhlAgc+t5IHtN7Vllk18mCkvpIu/z2bacXcjSFplZDG7p zmKgZMdofbT86b8v4Sl2g2ovjxp+EjgFjLyS0ddiffFY3l1UjbI7KkeMOhKOz09y 7OTseyTz0SaosgMrPKcz =wz9+ -----END PGP SIGNATURE----- --GVvAxVC98GTGJkeRPBbOljieBT48vuH7a--