From: "Jan D." <jan.h.d@swipnet.se>
To: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 719fd93: Redo the whole window offsets and coordinate translation for X.
Date: Thu, 26 Feb 2015 16:02:26 +0100 [thread overview]
Message-ID: <54EF3582.9080709@swipnet.se> (raw)
In-Reply-To: <jwvbnkgg1to.fsf-monnier+emacsdiffs@gnu.org>
Stefan Monnier skrev den 2015-02-26 15:56:
> Hi Jan,
>
>> --- a/src/xmenu.c
>> +++ b/src/xmenu.c
>> @@ -1211,13 +1211,25 @@ create_and_show_popup_menu (struct frame *f,
>> widget_value *first_wv,
>
> You missed the second definition of create_and_show_popup_menu in
> xmenu.c which still uses FRAME_OUTER_TO_INNER_DIFF_X.
>
Sloppy of me, I'm on it.
> [ Thinking out loud: We really should try and reduce code-duplication in
> those files. ]
>
Agreed
Jan D.
next prev parent reply other threads:[~2015-02-26 15:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150225191654.16399.81439@vcs.savannah.gnu.org>
[not found] ` <E1YQhS2-0004HH-Ir@vcs.savannah.gnu.org>
2015-02-26 14:56 ` [Emacs-diffs] master 719fd93: Redo the whole window offsets and coordinate translation for X Stefan Monnier
2015-02-26 15:02 ` Jan D. [this message]
2015-02-26 15:12 ` Damien Wyart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54EF3582.9080709@swipnet.se \
--to=jan.h.d@swipnet.se \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).