unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* [PATCH] for review - making use of {EXEEXT} more uniform in makefiles.
@ 2015-02-14  1:20 Pete Williamson
  2015-02-18  2:01 ` Pete Williamson
  0 siblings, 1 reply; 10+ messages in thread
From: Pete Williamson @ 2015-02-14  1:20 UTC (permalink / raw)
  To: emacs-devel

[-- Attachment #1: Type: text/plain, Size: 2410 bytes --]

I humbly submit my first patch for feedback and consideration.  My
apologies in advance if I am not following the proper protocol for a
patch email, I'm new to this (I did look at several other [PATCH]
emails.)

Rationale: I'm porting Emacs to a new platform, and we need to have a
file extension on all
executables for this platform when we run the executables. In several
places in the makefile,
no extension is used.  This catches the places that I ran into, and
uses the {EXEEXT}
extension to make sure the proper file name extension is used to
launch programs by.

Motivating case:
I'm porting Emacs to the Chromebook using the NaCl API, and we need
for executables to have the .nexe extension.  Even when running Emacs
during the build process on the host Linux build machine  (for
instance to create leim-list.el or build documentation), we need the
proper extension so that the machine emulator is not confused.

I have tested this by building and running Emacs on Ubuntu 14 (only),
let me know if it is expected to test in more places.

All feedback and comments are welcome.

The patch file is below, here is a text version of the diff (since it
is a small patch)

diff --git a/leim/Makefile.in b/leim/Makefile.in
index 573acf7..70f2aca 100644
--- a/leim/Makefile.in
+++ b/leim/Makefile.in
@@ -47,7 +47,7 @@ unexport EMACSDATA EMACSDOC EMACSPATH

 # Which Emacs to use to convert TIT files to Emacs Lisp files,
 # and generate the file leim-list.el.
-EMACS = ../src/emacs
+EMACS = ../src/emacs{EXEEXT}

 # How to run Emacs.
 # Prevent any setting of EMACSLOADPATH in user environment causing problems.
diff --git a/lib-src/Makefile.in b/lib-src/Makefile.in
index d2705e7..d08aac5 100644
--- a/lib-src/Makefile.in
+++ b/lib-src/Makefile.in
@@ -21,7 +21,7 @@
 SHELL = @SHELL@

 # Following ../lisp/Makefile.in.
-EMACS = ../src/emacs
+EMACS = ../src/emacs{EXEEXT}
 EMACSOPT = -batch --no-site-file --no-site-lisp

 # ==================== Things `configure' will edit ====================
diff --git a/lisp/Makefile.in b/lisp/Makefile.in
index e5cfc63..3b0d109 100644
--- a/lisp/Makefile.in
+++ b/lisp/Makefile.in
@@ -47,7 +47,7 @@ am__v_GEN_1 =
 # We never change directory before running Emacs, so a relative file
 # name is fine, and makes life easier.  If we need to change
 # directory, we can use emacs --chdir.
-EMACS = ../src/emacs
+EMACS = ../src/emacs{EXEEXT}

 # Command line flags for Emacs.

[-- Attachment #2: 0001-Use-EXEEXT-more-uniformly-in-makefiles-when-running-.patch --]
[-- Type: text/x-patch, Size: 1859 bytes --]

From 8d8cba85c2e4298e40442069368912e68149fb2f Mon Sep 17 00:00:00 2001
From: Pete Williamson <petewil@chromium.org>
Date: Fri, 13 Feb 2015 16:59:39 -0800
Subject: [PATCH] Use {EXEEXT} more uniformly in makefiles when running
 executables.

When porting Emacs to run on NaCl, we need to make sure that we always
call it with the proper extension (.nexe in this case) during the build,
when Emacs has to run to generate leim-list.el and documentation.
---
 leim/Makefile.in    | 2 +-
 lib-src/Makefile.in | 2 +-
 lisp/Makefile.in    | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/leim/Makefile.in b/leim/Makefile.in
index 573acf7..70f2aca 100644
--- a/leim/Makefile.in
+++ b/leim/Makefile.in
@@ -47,7 +47,7 @@ unexport EMACSDATA EMACSDOC EMACSPATH
 
 # Which Emacs to use to convert TIT files to Emacs Lisp files,
 # and generate the file leim-list.el.
-EMACS = ../src/emacs
+EMACS = ../src/emacs{EXEEXT}
 
 # How to run Emacs.
 # Prevent any setting of EMACSLOADPATH in user environment causing problems.
diff --git a/lib-src/Makefile.in b/lib-src/Makefile.in
index d2705e7..d08aac5 100644
--- a/lib-src/Makefile.in
+++ b/lib-src/Makefile.in
@@ -21,7 +21,7 @@
 SHELL = @SHELL@
 
 # Following ../lisp/Makefile.in.
-EMACS = ../src/emacs
+EMACS = ../src/emacs{EXEEXT}
 EMACSOPT = -batch --no-site-file --no-site-lisp
 
 # ==================== Things `configure' will edit ====================
diff --git a/lisp/Makefile.in b/lisp/Makefile.in
index e5cfc63..3b0d109 100644
--- a/lisp/Makefile.in
+++ b/lisp/Makefile.in
@@ -47,7 +47,7 @@ am__v_GEN_1 =
 # We never change directory before running Emacs, so a relative file
 # name is fine, and makes life easier.  If we need to change
 # directory, we can use emacs --chdir.
-EMACS = ../src/emacs
+EMACS = ../src/emacs{EXEEXT}
 
 # Command line flags for Emacs.
 
-- 
2.2.0.rc0.207.ga3a616c


^ permalink raw reply related	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2015-02-23 18:20 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-14  1:20 [PATCH] for review - making use of {EXEEXT} more uniform in makefiles Pete Williamson
2015-02-18  2:01 ` Pete Williamson
2015-02-20 18:49   ` Pete Williamson
2015-02-20 20:10     ` Michal Nazarewicz
2015-02-20 20:31       ` Paul Eggert
2015-02-20 21:58         ` Przemysław Wojnowski
2015-02-20 22:27           ` Paul Eggert
2015-02-23 17:55         ` Pete Williamson
2015-02-23 18:17           ` Michal Nazarewicz
2015-02-23 18:20           ` Paul Eggert

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).