From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] for review - making use of {EXEEXT} more uniform in makefiles. Date: Mon, 23 Feb 2015 10:20:33 -0800 Organization: UCLA Computer Science Department Message-ID: <54EB6F71.30502@cs.ucla.edu> References: <54E79986.4000909@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------040907080608090701040406" X-Trace: ger.gmane.org 1424715676 7565 80.91.229.3 (23 Feb 2015 18:21:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 23 Feb 2015 18:21:16 +0000 (UTC) Cc: Michal Nazarewicz , emacs-devel@gnu.org To: Pete Williamson Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 23 19:21:10 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YPxcw-0003c7-4r for ged-emacs-devel@m.gmane.org; Mon, 23 Feb 2015 19:21:06 +0100 Original-Received: from localhost ([::1]:44914 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YPxcv-0001z6-Ie for ged-emacs-devel@m.gmane.org; Mon, 23 Feb 2015 13:21:05 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47238) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YPxcZ-0001ys-1f for emacs-devel@gnu.org; Mon, 23 Feb 2015 13:20:44 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YPxcU-0007jz-PA for emacs-devel@gnu.org; Mon, 23 Feb 2015 13:20:42 -0500 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:54856) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YPxcU-0007jr-90 for emacs-devel@gnu.org; Mon, 23 Feb 2015 13:20:38 -0500 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 4D4EDA60009; Mon, 23 Feb 2015 10:20:37 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BjQUf0UaSB4c; Mon, 23 Feb 2015 10:20:36 -0800 (PST) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 45B16A60007; Mon, 23 Feb 2015 10:20:36 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:183426 Archived-At: This is a multi-part message in MIME format. --------------040907080608090701040406 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Thanks, I installed the attached patch into Emacs master. It's the same as your patch, but with the ChangeLogs redone to match our current style. (Admittedly our current ChangeLog style is complex; on my list of things to do is simplify this; please see .) This patch is small enough that it can be installed as a tiny change without copyright papers (and that's why it's marked "(tiny change)" in the attached patch). If you would like to get more changes installed in the future, would you be willing to jump through the copyright-paperwork hoops? If so, please reply privately and I'll send you the info needed to get the ball rolling on that. --------------040907080608090701040406 Content-Type: text/x-patch; name="exeext.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="exeext.patch" diff --git a/leim/ChangeLog b/leim/ChangeLog index 4bda9a6..a8dbca2 100644 --- a/leim/ChangeLog +++ b/leim/ChangeLog @@ -1,3 +1,10 @@ +2015-02-23 Pete Williamson (tiny change) + + Use ${EXEEXT} more uniformly in makefiles + When porting Emacs to run on NaCl, we need to make sure that we always + call it with the proper extension (.nexe in this case) during the build. + * Makefile.in (EMACS): Append ${EXEEXT}. + 2015-01-04 Paul Eggert Less 'make' chatter for leim diff --git a/leim/Makefile.in b/leim/Makefile.in index 573acf7..2ec03db 100644 --- a/leim/Makefile.in +++ b/leim/Makefile.in @@ -47,7 +47,7 @@ unexport EMACSDATA EMACSDOC EMACSPATH # Which Emacs to use to convert TIT files to Emacs Lisp files, # and generate the file leim-list.el. -EMACS = ../src/emacs +EMACS = ../src/emacs${EXEEXT} # How to run Emacs. # Prevent any setting of EMACSLOADPATH in user environment causing problems. diff --git a/lib-src/ChangeLog b/lib-src/ChangeLog index 4ac9638..5c55bce 100644 --- a/lib-src/ChangeLog +++ b/lib-src/ChangeLog @@ -1,3 +1,8 @@ +2015-02-23 Pete Williamson (tiny change) + + Use ${EXEEXT} more uniformly in makefiles + * Makefile.in (EMACS): Append ${EXEEXT}. + 2015-02-20 Paul Eggert Simplify binary I/O configuration diff --git a/lib-src/Makefile.in b/lib-src/Makefile.in index d2705e7..6b5d379 100644 --- a/lib-src/Makefile.in +++ b/lib-src/Makefile.in @@ -21,7 +21,7 @@ SHELL = @SHELL@ # Following ../lisp/Makefile.in. -EMACS = ../src/emacs +EMACS = ../src/emacs${EXEEXT} EMACSOPT = -batch --no-site-file --no-site-lisp # ==================== Things `configure' will edit ==================== diff --git a/lisp/ChangeLog b/lisp/ChangeLog index 2c22ed2..d401852 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog @@ -1,3 +1,8 @@ +2015-02-23 Pete Williamson (tiny change) + + Use ${EXEEXT} more uniformly in makefiles + * Makefile.in (EMACS): Append ${EXEEXT}. + 2015-02-23 Sam Steingold * files.el (recover-session): Handle `auto-save-list-file-prefix' diff --git a/lisp/Makefile.in b/lisp/Makefile.in index e5cfc63..22d5ddc 100644 --- a/lisp/Makefile.in +++ b/lisp/Makefile.in @@ -47,7 +47,7 @@ am__v_GEN_1 = # We never change directory before running Emacs, so a relative file # name is fine, and makes life easier. If we need to change # directory, we can use emacs --chdir. -EMACS = ../src/emacs +EMACS = ../src/emacs${EXEEXT} # Command line flags for Emacs. --------------040907080608090701040406--