From: Paul Eggert <eggert@cs.ucla.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Omitting Windows-specific parts from infrastructure changes
Date: Sun, 18 Jan 2015 10:09:43 -0800 [thread overview]
Message-ID: <54BBF6E7.3090802@cs.ucla.edu> (raw)
In-Reply-To: <834mrp24b1.fsf@gnu.org>
Eli Zaretskii wrote:
> I'm sure when you do such changes, you
> grep (or otherwise search) the whole tree for relevant places
No, I hardly ever do that. For example, I don't look at the Lisp code if I'm
changing some aspect of the C code that shouldn't affect Lisp. And in instances
like the strcpy/stpcpy change, where the changes' effects don't bleed into the
MS-Windows port, I don't look at the MS-Windows code. In this sense the
MS-Windows code is like the OS X code, or like any other part of the Emacs
source code for that matter.
Ideally, the MS-Windows code would be a completely separate module, so that
changes in the Emacs core would not affect it and non-MS-Windows developers
would never need to worry about it. We're obviously not there, as we have too
many dependencies between the core and the MS-Windows code, one of the symptoms
of which is too many "#ifdef WINDOWSNT" directives sprinkled throught the core
modules. In some aspects, though, we do have good separation, and this kind of
separation should be encouraged, and it's good when developers can take
advantage of it.
next prev parent reply other threads:[~2015-01-18 18:09 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-16 9:54 Omitting Windows-specific parts from infrastructure changes Eli Zaretskii
2015-01-17 3:39 ` Paul Eggert
2015-01-17 8:34 ` Eli Zaretskii
2015-01-18 18:09 ` Paul Eggert [this message]
2015-01-18 18:23 ` Eli Zaretskii
2015-01-18 19:25 ` Paul Eggert
2015-01-18 19:50 ` Eli Zaretskii
2015-01-18 20:34 ` Paul Eggert
2015-01-19 16:03 ` Eli Zaretskii
2015-01-19 18:00 ` Paul Eggert
2015-01-19 18:32 ` Eli Zaretskii
2015-01-19 22:14 ` Paul Eggert
2015-01-20 16:32 ` Eli Zaretskii
2015-01-20 21:28 ` Paul Eggert
2015-01-21 15:48 ` Eli Zaretskii
2015-01-21 17:32 ` Paul Eggert
2015-01-21 17:55 ` Eli Zaretskii
2015-01-21 19:39 ` Paul Eggert
2015-01-21 20:07 ` Dmitry Gutov
2015-01-21 20:38 ` Eli Zaretskii
2015-01-21 20:08 ` David Kastrup
2015-01-21 20:49 ` Eli Zaretskii
2015-01-21 20:57 ` David Kastrup
2015-01-22 3:53 ` Eli Zaretskii
2015-01-21 20:30 ` Eli Zaretskii
2015-01-21 20:49 ` David Kastrup
2015-01-22 3:51 ` Eli Zaretskii
2015-01-22 14:20 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54BBF6E7.3090802@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).