From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Generalizing find-definition Date: Fri, 19 Dec 2014 16:34:00 +0200 Message-ID: <54943758.9030004@yandex.ru> References: <20141102151524.0d9c665c@forcix> <86ppbqn841.fsf@yandex.ru> <86mw6o3k28.fsf@yandex.ru> <548F5B60.8050509@yandex.ru> <548F5FFD.5010703@yandex.ru> <548F66B3.3050103@yandex.ru> <54901FEB.1090704@yandex.ru> <5490962D.7010105@yandex.ru> <5490A6B5.7020308@yandex.ru> <86ioh8ax2b.fsf@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1418999692 7497 80.91.229.3 (19 Dec 2014 14:34:52 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 19 Dec 2014 14:34:52 +0000 (UTC) Cc: emacs-devel To: Helmut Eller Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 19 15:34:45 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Y1ydh-0004IV-Ah for ged-emacs-devel@m.gmane.org; Fri, 19 Dec 2014 15:34:45 +0100 Original-Received: from localhost ([::1]:58970 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y1ydg-0001gt-RS for ged-emacs-devel@m.gmane.org; Fri, 19 Dec 2014 09:34:44 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45827) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y1ydK-0001fu-FB for emacs-devel@gnu.org; Fri, 19 Dec 2014 09:34:31 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y1ydB-0006x7-EJ for emacs-devel@gnu.org; Fri, 19 Dec 2014 09:34:22 -0500 Original-Received: from mail-wi0-x231.google.com ([2a00:1450:400c:c05::231]:54415) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y1ydB-0006wv-6p for emacs-devel@gnu.org; Fri, 19 Dec 2014 09:34:13 -0500 Original-Received: by mail-wi0-f177.google.com with SMTP id l15so1957792wiw.16 for ; Fri, 19 Dec 2014 06:34:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=Y2LoVlsuYt0znMYJKf6Uan+hukNXyLfqw9ug/D6ge0o=; b=RB95f+YZzBqrus0MzJBYuev7rS0mXRpjgnBNgAgRDlD3T1l5kr9ggHhdWLWR1100lc 9V4OcsPVjD0iC+jNRrn3cyIS3QdfzE0bsz59YUlqF02tzv45KDwAr8WUr1v6k0rDXTr1 CZwmI0L2/RE6r+bqodxYdQWCCRNrppIX4iJI+MkrKNop0xaAVB65Olk8poRAZqVNRkgB D/f9cIkyPFSkt8N5n7OQ+KkgayQtdBYiC9Vx3B3pRhHI8YR33XUzH2X2FI50ncMt41e8 SP0HS7FcjzpU3YMFpn6p/2hU0ab5jmUzXPhI3BpbaGKp/EFDn+7c6pSV2f81Ou/5FjtK ywUw== X-Received: by 10.194.200.1 with SMTP id jo1mr15827395wjc.64.1418999652570; Fri, 19 Dec 2014 06:34:12 -0800 (PST) Original-Received: from [192.168.1.2] ([82.102.93.54]) by mx.google.com with ESMTPSA id pf4sm12911290wjb.36.2014.12.19.06.34.09 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 Dec 2014 06:34:12 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c05::231 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:180331 Archived-At: On 12/19/2014 10:49 AM, Helmut Eller wrote: > xref-goto-xref should be rewritten as: Ok, thanks. > (define-derived-mode xref--xref-buffer-mode fundamental-mode "XREF" > "Mode for displaying cross refenences." > (setq buffer-read-only t) > (setq next-error-function #'xref--next-error-function) > (setq next-error-last-buffer (current-buffer))) This looks dubious to me. What if I already have a compilation buffer open, and I'm using `xref-find-definitions' to follow the implementation of some code near one of the errors? This seems like it'll break the error chain I'm currently following. Also, when I'm using xref-find-definitions (as opposed to the other xref-find- functions), I'm very unlikely to want to visit all results. It's usually just one that I'm after.