From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?UTF-8?B?UHJ6ZW15c8WCYXcgV29qbm93c2tp?= Newsgroups: gmane.emacs.devel Subject: Re: More metaproblem Date: Wed, 10 Dec 2014 21:09:41 +0100 Message-ID: <5488A885.4000400@cumego.com> References: <20141203142859.24393.98673@vcs.savannah.gnu.org> <20141203192721.GE12748@thyrsus.com> <547F6774.50700@cs.ucla.edu> <838uio5vjw.fsf@gnu.org> <20141203211447.GB15111@thyrsus.com> <871toge5zw.fsf@floss.red-bean.com> <83388v6hsq.fsf@gnu.org> <87egsftgd5.fsf@ktab.red-bean.com> <83egsf3yci.fsf@gnu.org> <87iohq6nvn.fsf@ktab.red-bean.com> <85bnnhkuep.fsf@stephe-leake.org> <857fy4ipsd.fsf@stephe-leake.org> <85y4qjdsg0.fsf@stephe-leake.org> <548616BE.3050701@cumego.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1418242209 14296 80.91.229.3 (10 Dec 2014 20:10:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 10 Dec 2014 20:10:09 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 10 21:10:03 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XynaD-0005SI-5D for ged-emacs-devel@m.gmane.org; Wed, 10 Dec 2014 21:10:01 +0100 Original-Received: from localhost ([::1]:47731 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XynaC-0002rH-Kp for ged-emacs-devel@m.gmane.org; Wed, 10 Dec 2014 15:10:00 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38861) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xyna2-0002jv-SI for emacs-devel@gnu.org; Wed, 10 Dec 2014 15:09:56 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XynZw-0005ro-Vj for emacs-devel@gnu.org; Wed, 10 Dec 2014 15:09:50 -0500 Original-Received: from smtp11.iq.pl ([86.111.242.220]:40339) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XynZw-0005qq-LW for emacs-devel@gnu.org; Wed, 10 Dec 2014 15:09:44 -0500 Original-Received: (qmail 14854 invoked from network); 10 Dec 2014 20:09:42 -0000 Original-Received: from unknown (HELO [192.168.1.106]) (esperanto@cumego.com@[159.205.31.128]) (envelope-sender ) by smtp11.iq.pl with AES128-SHA encrypted SMTP for ; 10 Dec 2014 20:09:42 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 In-Reply-To: <548616BE.3050701@cumego.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 86.111.242.220 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:179697 Archived-At: -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 W dniu 08.12.2014 o 22:23, Przemysław Wojnowski pisze: > Hi. [...] > 3. What are coding conventions, if are not language-wide (K&R for C?, what > about elisp?). Coding standards are mentioned in CONTRIBUTE. Sorry, my bad. I've found also the following: https://github.com/bbatsov/emacs-lisp-style-guide But don't know if you use it. > How about clean code > (http://www.amazon.com/Clean-Code-Handbook-Software-Craftsmanship/dp/0132350882)? > > Can split a long function into couple cohesive ones or you don't care about > readability? What about this one? Is refactoring to small, cohesive functions accepted? For example function abbrev--before-point from the first elisp file abbrev.el is quite big and I can imagine it's hard to test automatically. It could be split into couple smaller ones on single level of abstraction. Such functions would be easier to test and understand. Cheers, Przemyslaw -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUiKh/AAoJEC3CE3LuBFUoHlkQAI1uB3u1g/S/fPD7dZIQaeEU bRw6UbgmgFQJO+V2RJhkh0T+mfTvXUX9GoLVcVEgOdh7QBF435svgW4OXQt7S6tH pXmXNhBWO7cqiKeoLyzJp3Il7E5mdvaqREGnxeuXQ0KBgipWW06/24U4oprudF6a ntHjNyfSGlq8/hjR9uURQmNDvT5WS4FE3XtmOw+q0pWpnxh01eNHaepFXQY5qjOK 6MwhauveL5QmvMXbEIu7yYc+MYbWHscr1pRYBMjrM3GWJDjX0C/inriWiIlrZqXQ cxq5jWXEh0wBEG3P89RCr3ppfgtwuHq3zZJNERJDrOR2fmtSw+vQXnD/8ds8Yw8Y k9zkIR6H/rD8NVUMSlFzXGeDuA0sr4t/XH9l9cMt0sedkZ2B3/WUzYTRENmdJAro mkoCZLTLjl0qP5YezRm3ONRwlwp8EVWLBSgC2AFqxP0/boMqIZ27NRrfoT8ohi/9 iWWKPjbZRsqC9xcvLFT+UxUJo/vNyFKBtxHKyxLB3M2K9jmCbQYZDRTAdj1BjmPj mg+VtUDaEAmgiejHPh0ZCVNig+DCV6xBC6Klv3b9c0csXZgjKBFqgyb1PTKzlMOM Y8vTaRSwONHTHv6uoY2FVHWS67TGYmjLpUT+VWDR+5L0PIFWwexEFH6ooUs2nT/Y KK2Af4FdBQOevB0JS1lo =z/B5 -----END PGP SIGNATURE-----