From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master e820f16: Added file-tree-walk to files.el. Date: Wed, 03 Dec 2014 11:21:45 -0800 Organization: UCLA Computer Science Department Message-ID: <547F62C9.6060707@cs.ucla.edu> References: <20141203142859.24393.98673@vcs.savannah.gnu.org> <87tx1cu1nm.fsf@zigzag.favinet> <83egsg61yq.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1417634539 27308 80.91.229.3 (3 Dec 2014 19:22:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 3 Dec 2014 19:22:19 +0000 (UTC) To: Tom , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 03 20:22:13 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XwFV7-00053U-4V for ged-emacs-devel@m.gmane.org; Wed, 03 Dec 2014 20:22:13 +0100 Original-Received: from localhost ([::1]:43016 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwFV6-0002UM-I4 for ged-emacs-devel@m.gmane.org; Wed, 03 Dec 2014 14:22:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43402) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwFUx-0002UC-0d for emacs-devel@gnu.org; Wed, 03 Dec 2014 14:22:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XwFUp-000523-UA for emacs-devel@gnu.org; Wed, 03 Dec 2014 14:22:02 -0500 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:37975) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwFUp-00051l-OQ for emacs-devel@gnu.org; Wed, 03 Dec 2014 14:21:55 -0500 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 2E9E1A600B4; Wed, 3 Dec 2014 11:21:54 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gTiMvW1YpHfA; Wed, 3 Dec 2014 11:21:48 -0800 (PST) Original-Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 3E6E4A600B2; Wed, 3 Dec 2014 11:21:48 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 131.179.128.62 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:178755 Archived-At: On 12/03/2014 10:36 AM, Tom wrote: > Just add a script which checks the commit message and if there > is no proper changeLog-formatted entry in the commit message then > it rejects the commit. > We already have such scripts in build-aux/git-hooks/*, which I wrote recently and which are installed in .git/hooks when you run autogen.sh. I made them reasonably permissive, since I figured that people would have enough trouble with the bzr-to-git transition that they wouldn't appreciate nagging about ChangeLog format too. Also, the hooks are optional, in the sense that not everybody runs autogen.sh, or it may be a while before they run autogen.sh, or perhaps they commit in some way that bypasses the hooks. At some point I suppose we could tighten up the hooks and make them less easy to bypass..