From: Dmitry Gutov <dgutov@yandex.ru>
To: esr@thyrsus.com
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: Inadequate branch support in VC
Date: Sat, 22 Nov 2014 17:44:16 +0200 [thread overview]
Message-ID: <5470AF50.7040406@yandex.ru> (raw)
In-Reply-To: <20141120173052.GA8690@thyrsus.com>
On 11/20/2014 07:30 PM, Eric S. Raymond wrote:
> The sort of good news: there is an amend capability. Nothing newer than
> svn supports it, though - in particular, the git back end could but does not.
> (SRC wlll support it.) It's accessed through log-view, which is ... even
> more confusing than the rest of the code.
Huh, I didn't know about that.
First, the git backend does support amending, but in a very different
way (press `C-c C-e' in log-edit buffer, when making a new commit). That
doesn't allow amending when you have to modified files, though, which is
something that I do often. Improving that would be good.
Second, `log-view-modify-change-comment' doesn't seem to support modern
backends at all because `log-view-extract-comment' unconditionally calls
`log-view-current-file'. This should be easy to fix.
Third, doing message editing in log-view might be a natural way to go
about it, but editing any but the last commit (and even it, if it's been
pushed) is a dangerous operation in Git, which we shouldn't make too
easy for users to perform.
Should there be, like, a check that the given comment is not reachable
from any of the "remote" refs?
> Dmitri is correct. VC needs a set of branching primitives:
> get-current-branch, set-current-branch, create-branch, delete-branch,
> rename-branch. And we need a standard way to exercise them in the
> UI. Both are presently lacking.
You probably meant Eli here. :)
prev parent reply other threads:[~2014-11-22 15:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-18 16:08 How to switch Git branches with VC? Eli Zaretskii
2014-11-18 19:15 ` Dmitry Gutov
2014-11-19 18:39 ` Eli Zaretskii
2014-11-20 16:00 ` Dmitry Gutov
2014-11-20 17:03 ` Eli Zaretskii
2014-11-20 17:33 ` Eric S. Raymond
2014-11-20 17:30 ` Inadequate branch support in VC Eric S. Raymond
2014-11-22 12:39 ` Thien-Thi Nguyen
2014-11-22 15:44 ` Dmitry Gutov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5470AF50.7040406@yandex.ru \
--to=dgutov@yandex.ru \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=esr@thyrsus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).